Consistently adjust the padding for all form selects

It seems Firefox fixed their longstanding bug, which caused the
workaround in PatternFly (who adopted it from us) to no longer be
relevant. I adjusted our own workaround, but it didn't apply as
PatternFly also (at some point in time) changed the DOM so the selector
no longer matched.

We'll want to communicate this with PF to get PF6 fixed. Possibly even
PF5 too, as it apparently changed in Firefox recently, and therefore
newer versions of Firefox will "break" the expected layout without
addressing it in PF directly (or with a workaround in codebases).

Author: garrett

pkg/lib/patternfly/patternfly-5-overrides.scss

@@ -57,16 +57,9 @@ to wrap around when there isn't enough space.
 /* (This can be seen when the longest text is selected on a non-stretched select) */
 /* Upstream: https://github.com/patternfly/patternfly/issues/4387 */
 /* Cockpit-Podman: https://github.com/cockpit-project/cockpit-podman/issues/755 */
-select.pf-v5-c-form-control {
+.pf-v5-c-form-control > select {
   --pf-v5-c-form-control--PaddingRight: 41px;
   --pf-v5-c-form-control--PaddingLeft: 8px;
-
-  // Firefox's select text has additional padding (4px)
-  /* stylelint-disable-next-line at-rule-no-vendor-prefix */
-  @-moz-document url-prefix() {
-    --pf-v5-c-form-control--PaddingRight: 37px;
-    --pf-v5-c-form-control--PaddingLeft: 4px;
-  }
 }
 
 // Fix the double-spacing issue in the non-deprecated split buttons