From 0e999fc76e870e0da84c0152227435a04603c8b2 Mon Sep 17 00:00:00 2001 From: "John Paul E. Balandan, CPA" Date: Fri, 17 Jan 2025 18:35:35 +0800 Subject: [PATCH] Fix impossible conditional in test --- tests/system/Cache/CacheFactoryTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system/Cache/CacheFactoryTest.php b/tests/system/Cache/CacheFactoryTest.php index d8d301efa4a7..bc4c25b1f9fa 100644 --- a/tests/system/Cache/CacheFactoryTest.php +++ b/tests/system/Cache/CacheFactoryTest.php @@ -96,8 +96,8 @@ public function testHandlesBadHandler(): void $this->config->handler = 'dummy'; - if (str_starts_with('win', strtolower(php_uname()))) { - $this->assertTrue(true); // can't test properly if we are on Windows + if (is_windows()) { + $this->markTestSkipped('Cannot test this properly on Windows.'); } else { $this->assertInstanceOf(DummyHandler::class, $this->cacheFactory->getHandler($this->config, 'wincache', 'wincache')); }