diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php index 51ed022d131d..36a5f23f7af7 100644 --- a/system/Database/BaseBuilder.php +++ b/system/Database/BaseBuilder.php @@ -3175,6 +3175,7 @@ protected function compileWhereHaving(string $qbKey): string ) { continue; } + // $matches = [ // 0 => '(test <= foo)', /* the whole thing */ // 1 => '(', /* optional */ @@ -3184,7 +3185,7 @@ protected function compileWhereHaving(string $qbKey): string // 5 => ')' /* optional */ // ]; - if (isset($matches[4]) && $matches[4] !== '') { + if ($matches[4] !== '') { $protectIdentifiers = false; if (str_contains($matches[4], '.')) { $protectIdentifiers = true; diff --git a/utils/phpstan-baseline/isset.offset.neon b/utils/phpstan-baseline/isset.offset.neon deleted file mode 100644 index 5fa42018f231..000000000000 --- a/utils/phpstan-baseline/isset.offset.neon +++ /dev/null @@ -1,8 +0,0 @@ -# total 1 error - -parameters: - ignoreErrors: - - - message: '#^Offset 4 on array\{string, string, string, string, string, string\} in isset\(\) always exists and is not nullable\.$#' - count: 1 - path: ../../system/Database/BaseBuilder.php diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon index 3e7f2ca5fa2f..7301539443d0 100644 --- a/utils/phpstan-baseline/loader.neon +++ b/utils/phpstan-baseline/loader.neon @@ -16,7 +16,6 @@ includes: - empty.property.neon - function.alreadyNarrowedType.neon - generator.valueType.neon - - isset.offset.neon - isset.property.neon - method.alreadyNarrowedType.neon - method.childParameterType.neon