Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on Fabric Loader 0.12.0+ (and 1.18+) #5

Closed
triphora opened this issue Oct 7, 2021 · 3 comments · Fixed by #7
Closed

Broken on Fabric Loader 0.12.0+ (and 1.18+) #5

triphora opened this issue Oct 7, 2021 · 3 comments · Fixed by #7
Labels
blocked Requires external/dependency issues to be fixed bug Something isn't working

Comments

@triphora
Copy link

triphora commented Oct 7, 2021

A crash on loader 0.12.1: https://hastebin.com/isixedepes.yaml
Same crash on loader 0.11.7: https://hastebin.com/axomarowit.yaml

See https://fabricmc.net/2021/10/03/loader-0120.html#mixin-compatibility for more info on what exactly changed in loader in regards to 0.12.
@comp500 comp500 added the bug Something isn't working label Nov 30, 2021
@comp500
Copy link
Owner

comp500 commented Nov 30, 2021

I should probably have linked this earlier: SpongePowered/Mixin#529 will make it possible to fix this issue (should I PR it to Fabric's fork too?)

@comp500 comp500 changed the title Fails to find mixins on Fabric Loader 0.12.0+ Broken on Fabric Loader 0.12.0+ (and 1.18+) Dec 4, 2021
@comp500 comp500 added the blocked Requires external/dependency issues to be fixed label Dec 4, 2021
@comp500 comp500 pinned this issue Dec 4, 2021
@MagicSweet-dev MagicSweet-dev mentioned this issue Dec 31, 2021
Merged
@sudofox
Copy link

sudofox commented Apr 8, 2022

Finally updating my installed mods to 1.18.2 , is this still blocked?

@srnyx
Copy link

srnyx commented Jun 7, 2022

Minecraft is now on 1.19, any plans on updating this?

comp500 pushed a commit that referenced this issue Jun 13, 2022
@MagicSweet-dev
Fix #5 by using field that isn't stripped by proguard (#7)
f5831f7 
* Update to 1.18.1

* Rearrangement

Now using reflection's getField() instead of getMethod() because seems like there's no "getMixins" anymore but there's still a field "mixins" hanging around

* updated gradle wrapper, fixed 1.18's java requirement

also tested in client 👍

* Downgrade base version to 1.17, fix #5

Still compatible with 1.18+ tho!
@comp500 comp500 unpinned this issue Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Requires external/dependency issues to be fixed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix of #5
4 participants
@comp500 @sudofox @srnyx @triphora