Skip to content

Add more checks like validating protos to CI #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mossaka opened this issue Jul 21, 2023 · 2 comments
Closed

Add more checks like validating protos to CI #191

Mossaka opened this issue Jul 21, 2023 · 2 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Jul 21, 2023

Originally posted by @cpuguy83 in #188 (comment)
@jsturtevant
Copy link
Contributor

I believe this was resoved with #81 since the build now includes generate_bindings

runwasi/Makefile

Lines 17 to 20 in 2dbde80

.PHONY: build
build:
cargo build -p containerd-shim-wasm --features generate_bindings $(RELEASE_FLAG)
cargo build $(RELEASE_FLAG)

@Mossaka Mossaka mentioned this issue Jul 24, 2023
Closed
@Mossaka
Copy link
Member Author

Mossaka commented Nov 3, 2023

It looks like #81 have resolved this issue.

@Mossaka Mossaka closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsturtevant @Mossaka