Skip to content

Commit 979a956

Browse files
committed
Change CI's rustup version to use rust-toolchain.toml 's version
and fix test's fail Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
1 parent 9d9cc05 commit 979a956

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

.github/workflows/ci.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ jobs:
2121

2222
- run: ./scripts/install-protobuf.sh
2323
shell: bash
24-
25-
- run: rustup toolchain install nightly --component rustfmt
26-
- run: cargo +nightly fmt --all -- --check
24+
# Remove the manual rustup nightly installation step
25+
# - run: rustup toolchain install nightly --component rustfmt
26+
- run: cargo fmt --all -- --check
2727

2828
# the "runc" and "containerd-shim" crates have `sync` code that is not covered by the workspace
2929
- run: cargo check -p runc --all-targets

crates/shim-protos/examples/ttrpc-server-async.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ impl Task for FakeServer {
6060
async fn main() {
6161
simple_logger::SimpleLogger::new().init().unwrap();
6262

63-
let tservice = create_task(Arc::new(Box::new(FakeServer::new())));
63+
let fakeserver = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
64+
let tservice = create_task(Arc::from(fakeserver));
6465

6566
let mut server = Server::new()
6667
.bind("unix:///tmp/shim-proto-ttrpc-001")

crates/shim-protos/examples/ttrpc-server.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ impl Task for FakeServer {
5757
fn main() {
5858
simple_logger::SimpleLogger::new().init().unwrap();
5959

60-
let tservice = create_task(Arc::new(Box::new(FakeServer::new())));
60+
let fakeserver = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
61+
let tservice = create_task(Arc::from(fakeserver));
6162

6263
let mut server = Server::new()
6364
.bind("unix:///tmp/shim-proto-ttrpc-001")

crates/shim-protos/tests/ttrpc.rs

+6-4
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ fn create_ttrpc_context() -> (
7272

7373
#[test]
7474
fn test_task_method_num() {
75-
let task = create_task(Arc::new(Box::new(FakeServer::new())));
75+
let fakeserver = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
76+
let task = create_task(Arc::from(fakeserver));
7677
assert_eq!(task.len(), 17);
7778
}
7879

@@ -96,7 +97,8 @@ fn test_create_task() {
9697
request.set_timeout_nano(10000);
9798
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));
9899

99-
let task = create_task(Arc::new(Box::new(FakeServer::new())));
100+
let fakeserver = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
101+
let task = create_task(Arc::from(fakeserver));
100102
let create = task.get("/containerd.task.v2.Task/Create").unwrap();
101103
create.handler(ctx, request).unwrap();
102104

@@ -136,8 +138,8 @@ fn test_delete_task() {
136138
request.set_payload(buf);
137139
request.set_timeout_nano(10000);
138140
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));
139-
140-
let task = create_task(Arc::new(Box::new(FakeServer::new())));
141+
let fakeserver = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
142+
let task = create_task(Arc::from(fakeserver));
141143
let delete = task.get("/containerd.task.v2.Task/Delete").unwrap();
142144
delete.handler(ctx, request).unwrap();
143145

crates/shim/src/asynchronous/publisher.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,8 @@ mod tests {
218218
let barrier2 = barrier.clone();
219219
let server_thread = tokio::spawn(async move {
220220
let listener = UnixListener::bind(&path1).unwrap();
221-
let service = create_events(Arc::new(Box::new(server)));
221+
let sserver = Box::new(server) as Box<dyn Events + Sync + Send>;
222+
let service = create_events(Arc::from(sserver));
222223
let mut server = Server::new()
223224
.set_domain_unix()
224225
.add_listener(listener.as_raw_fd())

0 commit comments

Comments
 (0)