Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the async feature a no-op on non-unix platforms #380

Closed
wants to merge 1 commit into from

Conversation

jprendes
Copy link
Contributor

Fixes #379

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@github-actions github-actions bot added the C-shim Containerd shim label Feb 28, 2025
@mxpv
Copy link
Member

mxpv commented Mar 12, 2025

Can you add some clarity around this?

@jprendes
Copy link
Contributor Author

Depending on rust-extensions while trying to maintain support for windows and for async (whenever possible) is challenging with the current setup, as containerd-shim fails to build on windows when the async feature is enabled.
Making the feature a no-op on windows would work around this issue, allowing the use of async on unix platforms, and sync on windows.

That being said, I am currently collaborating with ttrpc-rust to add async support for windows there.
Once that's merged I would like to give it a go to adding async support for windows here.
I think overall that would be better than what's proposed in this PR.

@jprendes jprendes closed this Mar 14, 2025
@jprendes jprendes deleted the async-win-noop branch March 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-shim Containerd shim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containerd-shim fails to build on Windows with the async feature enabled.
3 participants