Skip to content

Commit 44ca31f

Browse files
committed
removed unwanted dependency from built packages, update docker docs, downgrade back to python3.10 due to emane packaging on Ubuntu 24 for now
1 parent 7a5e42a commit 44ca31f

File tree

8 files changed

+73
-83
lines changed

8 files changed

+73
-83
lines changed

.github/workflows/daemon-checks.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ jobs:
77
runs-on: ubuntu-24.04
88
steps:
99
- uses: actions/checkout@v1
10-
- name: Set up Python 3.12
10+
- name: Set up Python
1111
uses: actions/setup-python@v1
1212
with:
13-
python-version: 3.12
13+
python-version: 3.10
1414
- name: install poetry
1515
run: |
1616
python -m pip install --upgrade pip

Makefile.am

-2
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ fpm -s dir -t rpm -n core \
100100
-d "tk" \
101101
-d "procps-ng" \
102102
-d "bash >= 3.0" \
103-
-d "ebtables" \
104103
-d "iproute" \
105104
-d "libev" \
106105
-d "net-tools" \
@@ -133,7 +132,6 @@ fpm -s dir -t deb -n core \
133132
-d "procps" \
134133
-d "libc6 >= 2.14" \
135134
-d "bash >= 3.0" \
136-
-d "ebtables" \
137135
-d "iproute2" \
138136
-d "libev4" \
139137
-d "nftables" \

configure.ac

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ if test "x$enable_daemon" = "xyes"; then
7979
want_python=yes
8080
want_linux_netns=yes
8181

82-
AM_PATH_PYTHON(3.12)
82+
AM_PATH_PYTHON(3.10)
8383
AS_IF([./venv/bin/python -m grpc_tools.protoc -h &> /dev/null], [], [AC_MSG_ERROR([grpc tools must be setup in venv, try setup.sh])])
8484

8585
AC_CHECK_PROG(sysctl_path, sysctl, $as_dir, no, $SEARCHPATH)

daemon/poetry.lock

+68-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

daemon/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ core-service-update = "core.scripts.serviceupdate:main"
2424
core-cleanup = "core.scripts.cleanup:main"
2525

2626
[tool.poetry.dependencies]
27-
python = "^3.12"
27+
python = "^3.10"
2828
fabric = "3.2.2"
2929
grpcio = "1.69.0"
3030
invoke = "2.2.0"

dockerfiles/Dockerfile.ospf-mdr-deb

-32
This file was deleted.

dockerfiles/Dockerfile.ospf-mdr-rpm

-33
This file was deleted.

docs/install_docker.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ git clone https://github.com/coreemu/core.git
2424
cd core
2525
# first you must build EMANE python bindings
2626
sudo docker build -t emane-python -f dockerfiles/Dockerfile.emane-python .
27-
# build ospf packages
28-
sudo docker build -t ospf-rpm -f dockerfiles/Dockerfile.ospf-mdr-rpm .
29-
sudo docker build -t ospf-deb -f dockerfiles/Dockerfile.ospf-mdr-deb .
30-
# build desired CORE image
27+
# build desired CORE image, OSPF is a build stage dependency within the file
3128
sudo docker build -t core -f dockerfiles/<Dockerfile> .
3229
```
3330

0 commit comments

Comments
 (0)