initial fixes

Author: xyzqm

gatsby-node.ts

@@ -495,7 +495,7 @@ exports.createSchemaCustomization = ({ actions }) => {
     type Xdm implements Node {
       body: String
       fileAbsolutePath: String
-      frontmatter: XdmFrontmatter
+      frontmatter: XdmFrontmatter!
       isIncomplete: Boolean
       cppOc: Int
       javaOc: Int
@@ -506,7 +506,7 @@ exports.createSchemaCustomization = ({ actions }) => {
 
     type XdmFrontmatter implements Node {
       id: String
-      title: String
+      title: String!
       author: String
       contributors: String
       description: String

src/api/(parsers)/usaco.ts

@@ -1,11 +1,14 @@
 export default function parseUsaco(url: string, htmlContent: string) {
   const id = url.split('=').at(-1);
+  if (!id) throw new Error(`${url} does not contain problem id`);
   const problem = htmlContent.match(/<h2> Problem (\d). (.*) <\/h2>/);
+  if (!problem) throw new Error(`Problem title not found at url ${url}`);
   const number = problem[1],
     title = problem[2];
   const contest = htmlContent.match(
     /<h2> USACO (\d+) (December|January|February|(?:US Open)) Contest, (Bronze|Silver|Gold|Platinum) <\/h2>/
   );
+  if (!contest) throw new Error(`Contest not found at url ${url}`);
   // year and month could be used someday idk
   const year = contest[1],
     month = contest[2],

src/atoms/editor.ts

@@ -1,4 +1,4 @@
-import { WritableAtom, atom } from 'jotai';
+import { atom } from 'jotai';
 import { atomFamily, atomWithStorage } from 'jotai/utils';
 import { Octokit } from 'octokit';
 import { fetchFileContent } from '../components/Editor/editorUtils';
@@ -8,7 +8,7 @@ import { formatProblems } from '../utils/prettierFormatter';
 export type EditorFile = {
   path: string;
   markdown: string;
-  problems: string;
+  problems?: string;
 };
 
 export const filesFamily = atomFamily((path: string) => {
@@ -47,16 +47,13 @@ const baseActiveFileAtom = atomWithStorage(
   'guide:editor:activeFile',
   null as string | null
 );
-// Writable type needed if strictNullChecks is false
-// TODO: remove this when strictNullChecks is true
-export type Writable<T> = WritableAtom<T, any[], unknown>;
 export const branchAtom = atomWithStorage('guide:editor:branch', null);
-export const tokenAtom = atom(null) as Writable<string | null>;
+export const tokenAtom = atom(null);
 export const octokitAtom = atom(get =>
   get(tokenAtom) === null ? null : new Octokit({ auth: get(tokenAtom) })
 );
-export const forkAtom = atom(undefined) as Writable<string | undefined | null>;
-export const baseTabAtom = atom('content') as Writable<'content' | 'problems'>;
+export const forkAtom = atom(undefined);
+export const baseTabAtom = atom('content');
 export const editingSolutionAtom = atom(get => {
   const activeFile = get(activeFileAtom);
   return activeFile && activeFile.path.startsWith('solutions');
@@ -84,10 +81,10 @@ export const githubInfoAtom = atom(
   async get => (await get(octokitAtom)?.request('GET /user'))?.data
 );
 export const activeFileAtom = atom(
-  get =>
-    get(baseActiveFileAtom) === null
-      ? null
-      : get(filesFamily(get(baseActiveFileAtom))),
+  get => {
+    const activeFile = get(baseActiveFileAtom);
+    return activeFile ? get(filesFamily(activeFile)) : null;
+  },
   (get, set, nextActiveFilePath) => {
     set(baseActiveFileAtom, nextActiveFilePath);
   }
@@ -100,7 +97,7 @@ export const filesListAtom = atomWithStorage<string[]>(
 
 export const openOrCreateExistingFileAtom = atom(
   null,
-  async (get, set, filePath: string | null) => {
+  async (get, set, filePath: string) => {
     if (get(filesListAtom).find(f => f === filePath)) {
       set(activeFileAtom, filePath);
     } else {
@@ -201,7 +198,8 @@ $\\texttt{func(var)}$
       problems: '',
     };
 
-    const updateProblemJSON = (json: string) => {
+    const updateProblemJSON = (json: string | undefined) => {
+      if (!json) return undefined;
       const updated = JSON.parse(json);
       Object.keys(updated).forEach(key => {
         if (key === 'MODULE_ID') return;
@@ -252,17 +250,17 @@ export const closeFileAtom = atom(null, (get, set, filePath: string) => {
     filesListAtom,
     get(filesListAtom).filter(file => file !== filePath)
   );
-  if (get(activeFileAtom).path === filePath) {
+  if (get(activeFileAtom)?.path === filePath) {
     const remainingFiles = get(filesListAtom);
     set(activeFileAtom, remainingFiles.length > 0 ? remainingFiles[0] : null);
   }
-  set(filesFamily(filePath), null);
+  filesFamily.remove(filePath);
 });
 
 const baseMonacoEditorInstanceAtom = atom({ monaco: null });
 export const monacoEditorInstanceAtom = atom(
   get => get(baseMonacoEditorInstanceAtom),
-  (get, _set, val) => {
+  (get, _set, val: any) => {
     get(baseMonacoEditorInstanceAtom).monaco = val;
   }
 );

src/components/Confetti/Particles.tsx

@@ -4,11 +4,11 @@ import { defaultShapes } from './confetti-shapes.js';
 import type { Particle, Shape } from './types';
 
 type State = {
-  particles: Array<Particle>;
+  particles: (Particle | null)[];
 };
 
 type ChildFnProps = {
-  particles: Array<Particle>;
+  particles: Particle[];
   generateParticles: () => void;
 };
 
@@ -78,7 +78,7 @@ class Particles extends React.PureComponent<Props, State> {
   };
 
   state = {
-    particles: [],
+    particles: [] as Particle[],
   };
 
   animationFrameId: number;

src/components/Confetti/types.ts

@@ -1,7 +1,7 @@
 export type Particle = {
   birth: number;
-  initialPosition: [number, number];
-  currentPosition: [number, number];
+  initialPosition: { x: number; y: number };
+  currentPosition: { x: number; y: number };
   spinForce: number;
   twistForce: number;
   currentSpin: number;

src/models/module.ts

@@ -15,12 +15,12 @@ export class ModuleLinkInfo {
     public id: string,
     public section: SectionID,
     public title: string,
-    public description?: string,
+    public description?: string | null,
     public frequency?: ModuleFrequency,
-    public isIncomplete?: boolean,
-    public cppOc: number = 0,
-    public javaOc: number = 0,
-    public pyOc: number = 0,
+    public isIncomplete?: boolean | null,
+    public cppOc: number | null = 0,
+    public javaOc: number | null = 0,
+    public pyOc: number | null = 0,
     public probs?: any,
     public gitAuthorTime?: any
   ) {

src/pages/editor.tsx

@@ -19,7 +19,7 @@ export default function EditorPageContainer(props: PageProps): JSX.Element {
     setHasMounted(true);
   }, []);
   if (!hasMounted) {
-    return null;
+    return <></>;
   }
   return <EditorPage {...props} />;
 }

src/stories/Tooltip.stories.tsx

@@ -22,12 +22,12 @@ const Template: Story<ComponentProps<typeof Tooltip>> = args => {
   const [show, setShow] = React.useState<boolean>(false);
   React.useEffect(() => {
     if (ref.current) setShow(true);
-  }, [ref.current]);
+  }, []);
 
   return (
     <div className="my-8" ref={ref}>
       {show && (
-        <Tooltip {...args} appendTo={() => ref.current} showOnCreate={true}>
+        <Tooltip {...args} appendTo={() => ref.current!} showOnCreate={true}>
           <span className="bg-gray-100 p-2 dark:bg-gray-700">
             Hover over me!
           </span>
@@ -67,7 +67,7 @@ const TextTooltipTemplate: Story<
   const [show, setShow] = React.useState<boolean>(false);
   React.useEffect(() => {
     if (ref.current) setShow(true);
-  }, [ref.current]);
+  }, []);
 
   return (
     <div className="my-8" ref={ref}>
@@ -121,7 +121,7 @@ const AsteriskTooltipTemplate: Story<
       {show && (
         <AsteriskComponent
           {...args}
-          appendTo={() => ref.current}
+          appendTo={() => ref.current!}
           showOnCreate={true}
         />
       )}

src/templates/moduleTemplate.tsx

@@ -25,6 +25,7 @@ export default function Template(props): JSX.Element {
     window.requestAnimationFrame(() => {
       try {
         const anchor = document.getElementById(hash.substring(1));
+        if (!anchor) throw new Error(`The anchor "${hash}" doesn't exist`);
         const offset = anchor.getBoundingClientRect().top + window.scrollY;
         window.scroll({ top: offset, left: 0 });
       } catch (e) {

src/templates/syllabusTemplate.tsx

@@ -146,17 +146,17 @@ export default function Template(props) {
   );
   const moduleProgressInfo = useModulesProgressInfo(moduleIDs);
   const problemIDs = [
-    ...new Set(data.problems.edges.map(x => x.node.uniqueId) as string[]),
+    ...new Set(data.problems.nodes.map(x => x.uniqueId) as string[]),
   ];
   const problemsProgressInfo = useProblemsProgressInfo(problemIDs);
 
   const useProgressBarForCategory = (category: (typeof section)[0]) => {
     const categoryModuleIDs = category.items.map(
       module => module.frontmatter.id
     );
-    const categoryProblemIDs = data.problems.edges
-      .filter(x => categoryModuleIDs.includes(x.node.module.frontmatter.id))
-      .map(x => x.node.uniqueId);
+    const categoryProblemIDs = data.problems.nodes
+      .filter(x => categoryModuleIDs.includes(x.module?.frontmatter.id ?? ''))
+      .map(x => x.uniqueId);
     const problemsProgressInfo = useProblemsProgressInfo(categoryProblemIDs);
     return (
       categoryProblemIDs.length > 1 && (
@@ -249,7 +249,7 @@ export default function Template(props) {
                           item.javaOc,
                           item.pyOc,
                           [],
-                          item.fields.gitAuthorTime
+                          item.fields?.gitAuthorTime
                         )
                       }
                     />
@@ -293,14 +293,12 @@ export const pageQuery = graphql`
     problems: allProblemInfo(
       filter: { module: { fields: { division: { eq: $division } } } }
     ) {
-      edges {
-        node {
-          uniqueId
-          name
-          module {
-            frontmatter {
-              id
-            }
+      nodes {
+        uniqueId
+        name
+        module {
+          frontmatter {
+            id
           }
         }
       }

src/utils/extract-searchable-text.ts

@@ -24,7 +24,7 @@ export default function extractSearchableText(node) {
 }
 
 function all(values) {
-  const result = [];
+  const result: string[] = [];
   const length = values.length;
   let index = -1;
 

src/utils/utils.ts

@@ -17,7 +17,7 @@ export const getModulesForDivision = (
       }
       return {
         ...allModules[k2 as string],
-        slug: `/${division}/${allModules[k2 as string].frontmatter.id}`,
+        slug: `/${division}/${allModules[k2 as string].frontmatter?.id}`,
       };
     }),
     description: k.description,

tsconfig.json

@@ -11,6 +11,7 @@
     "module": "esnext",
     "moduleResolution": "node",
     "skipLibCheck": true,
-    "strict": false
+    "strict": false,
+    "strictNullChecks": true
   }
 }