Skip to content

Commit 8db161a

Browse files
authored
Fix incorrect timeout log on evaluate requests (#442)
1 parent 83fad07 commit 8db161a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/evaluator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export class Evaluator {
170170
let timer: number | NodeJS.Timeout | undefined;
171171

172172
if (timeout !== undefined) {
173-
setTimeout(
173+
timer = setTimeout(
174174
() => {
175175
const response: ErrorResponse = {
176176
title: `Evaluation could not be completed in time for query "${reference}".`,

test/evaluator.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,8 @@ describe('An evaluator', () => {
351351

352352
await expect(evaluator.evaluate(query, {timeout: 10})).resolves.toBe('Carol');
353353

354+
jest.advanceTimersByTime(11);
355+
354356
expect(logger.error).not.toHaveBeenCalled();
355357
});
356358

0 commit comments

Comments
 (0)