Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support of an adjustment coefficient for the gas price #17

Closed
thomas-nguy opened this issue Jul 10, 2023 · 0 comments · Fixed by #28
Closed

[Core] Support of an adjustment coefficient for the gas price #17

thomas-nguy opened this issue Jul 10, 2023 · 0 comments · Fixed by #28
Assignees

Comments

@thomas-nguy
Copy link
Member

thomas-nguy commented Jul 10, 2023

  • Current code only support ETH as native currency for L2, it relied on the gas_adjustement package to define how much we are okay to pay for the L1 transaction

https://github.com/cronos-labs/zksync-era/tree/internal/core/bin/zksync_core/src/l1_gas_price

Tasks involve :

  • Create a new table or update existing table in DB to store the coefficient value (CRUD db functions need to be supported by the utility module). The value will be updated by the oracle service ([Core] Development of an oracle service #16)

  • Modify the l1_gas_price package and any reference to the gas_price (in web3 api endpoint) to be sure to multiple by the coefficient factor when fetching the gas price

  • Perform minimal changes is required to avoid diverging with upstream

@thomas-nguy thomas-nguy changed the title [Core] Support of a adjustment coefficient for the gas price [Core] Support of an adjustment coefficient for the gas price Jul 10, 2023
@JayT106 JayT106 self-assigned this Jul 12, 2023
@thomas-nguy thomas-nguy self-assigned this Jul 13, 2023
@thomas-nguy thomas-nguy removed their assignment Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants