Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: negative coin amount error when query supply liquid of non BaseCoinUnit #1099

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Dec 30, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.17%. Comparing base (d1d09c9) to head (7d46453).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   34.15%   34.17%   +0.01%     
==========================================
  Files         101      101              
  Lines       17319    17324       +5     
==========================================
+ Hits         5915     5920       +5     
  Misses      10453    10453              
  Partials      951      951              
Flag Coverage Δ
integration_tests 23.91% <100.00%> (+0.02%) ⬆️
integration_tests_byzantine 10.95% <0.00%> (-0.01%) ⬇️
integration_tests_gov 11.20% <0.00%> (-0.01%) ⬇️
integration_tests_grpc 11.20% <0.00%> (-0.01%) ⬇️
integration_tests_ibc 26.51% <100.00%> (+0.84%) ⬆️
integration_tests_ledger 11.18% <0.00%> (-0.01%) ⬇️
integration_tests_slow 11.18% <0.00%> (-0.01%) ⬇️
integration_tests_solomachine 10.98% <0.00%> (-0.01%) ⬇️
integration_tests_upgrade 11.20% <0.00%> (-0.01%) ⬇️
unit_tests 11.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe force-pushed the fix_liquid branch 2 times, most recently from 36a97f9 to cfa1565 Compare December 30, 2024 10:52
@mmsqe mmsqe marked this pull request as ready for review December 30, 2024 10:52
@mmsqe mmsqe requested a review from a team as a code owner December 30, 2024 10:52
CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe mmsqe added this pull request to the merge queue Dec 31, 2024
Merged via the queue into crypto-org-chain:master with commit 9d69185 Dec 31, 2024
33 of 35 checks passed
mmsqe added a commit that referenced this pull request Dec 31, 2024
Problem: negative coin amount error when query supply liquid of non BaseCoinUnit(backport: #1099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants