Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of "original" is wrong #7

Open
Toflar opened this issue Oct 17, 2013 · 4 comments
Open

Usage of "original" is wrong #7

Toflar opened this issue Oct 17, 2013 · 4 comments
Labels

Comments

@Toflar
Copy link
Contributor

Toflar commented Oct 17, 2013

It should include the whole path from the "languages_cto" configuration.

Otherwise you cannot use two files named "default" in different modules.

@discordier
Copy link
Member

@Toflar Is this still relevant?
Could you please provide a PR if so?

@Toflar
Copy link
Contributor Author

Toflar commented Nov 13, 2013

It is relevant! But I don't know how we could best fix this...

@discordier
Copy link
Member

What exactly are the circumstances where this issue may happen?

For different modules you have a different prefix or not?

@Toflar
Copy link
Contributor Author

Toflar commented Jan 13, 2014

Yes, the problem's located here: https://github.com/cyberspectrum/contao-toolbox/blob/master/src/CyberSpectrum/Command/ConvertToXliff.php#L81

This will create an original like tl_module or default etc.
Apparently origin is used to distinguish the resources from each other. So if you have a repository that contains multiple modules, they will override each other because every module might have a tl_module in languages.

So in my opinion the right way to create origin is to include system/modules/<extension_name> but I'm not sure. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants