Improve command line parsing and fast grabbing

Author: danielkonecny

src/ArgumentsParser.cpp

@@ -5,7 +5,7 @@
  * @version         1.0
  * @author          Daniel Konecny (xkonec75)
  * @organisation    Brno University of Technology - Faculty of Information Technologies
- * @date            02. 04. 2021
+ * @date            03. 04. 2021
  */
 
 
@@ -41,20 +41,19 @@ long long ArgumentsParser::LoadNumber(char* numberAsChars) {
     return numberAsInt;
 }
 
-
 void ArgumentsParser::PrintHelp () {
-    cout << "-v (verbose)       Print information about the camera state." << endl << 
-            "-n (number)        Set number of images to be taken by each camera." << endl <<
+    cout << "IMAGE GRABBER" << endl <<
+            "-v (verbose)       Print information about the camera state." << endl << 
+            "-t (time)          Set time (in ms) between images grabbed." << endl <<
             "-h (help)          Show help." << endl;
 }
 
-
 bool ArgumentsParser::ProcessArguments (int argc, char* argv[]) {
-    const char* const short_opts = "vn:h";
+    const char* const short_opts = "vt:h";
 
     const option long_opts[] = {
         {"verbose", no_argument, nullptr, 'v'},
-        {"number", required_argument, nullptr, 'n'},
+        {"time", required_argument, nullptr, 't'},
         {"help", no_argument, nullptr, 'h'},
         {nullptr, no_argument, nullptr, 0}
     };
@@ -71,9 +70,9 @@ bool ArgumentsParser::ProcessArguments (int argc, char* argv[]) {
                 verbose = true;
                 break;
 
-            case 'n':
+            case 't':
                 try {
-                    imageCount = (unsigned long long)LoadNumber(optarg);
+                    waitTime = (unsigned long long)LoadNumber(optarg);
                 }
                 catch (...) {
                     return false;
@@ -95,7 +94,6 @@ bool ArgumentsParser::IsVerbose() {
     return verbose;
 }
 
-
-unsigned long long int ArgumentsParser::GetImageCount () {
-    return imageCount;
+unsigned long long int ArgumentsParser::GetWaitTime () {
+    return waitTime;
 }

src/ArgumentsParser.h

@@ -5,13 +5,13 @@
  * @version         1.0
  * @author          Daniel Konecny (xkonec75)
  * @organisation    Brno University of Technology - Faculty of Information Technologies
- * @date            02. 04. 2021
+ * @date            03. 04. 2021
  */
 
 class ArgumentsParser {
 private:
 	bool verbose = false;
-	unsigned long long int imageCount = 0;
+	unsigned long long int waitTime = 10;
 
 	void PrintHelp ();
 
@@ -22,5 +22,5 @@ class ArgumentsParser {
 
     bool IsVerbose();
 
-    unsigned long long int GetImageCount ();
+    unsigned long long int GetWaitTime ();
 };

src/ImageEventHandler.cpp

@@ -24,7 +24,7 @@ using namespace Pylon;
 using namespace cv;
 
 
-ImageEventHandler::ImageEventHandler () {
+ImageEventHandler::ImageEventHandler (bool inputVerbose) {
     timestampFile.open("out/timestamps.csv");
     timestampFile << "\"image_file\",\"timestamp_in_ms\",\"iso_datetime\"\n";
 
@@ -36,6 +36,8 @@ ImageEventHandler::ImageEventHandler () {
     formatConverter.OutputPixelFormat = PixelType_BGR8packed;
 
     timeOffset = 0;
+
+    verbose = inputVerbose;
 }
 
 ImageEventHandler::~ImageEventHandler () {
@@ -92,10 +94,12 @@ void ImageEventHandler::OnImageGrabbed (
         // Write info to CSV file.
         timestampFile << "\"" << imgNameString << "\"," << timestamp
                       << ",\"" << datetimeString << "\"\n";
-        cout << "Grabbed image " << imgNameString << " at " << datetimeString << endl;
+        if (verbose) {
+            cout << "Grabbed image " << imgNameString << " at " << datetimeString << endl;
+        }
     }
     else {
-        cout << "Error: " << std::hex << ptrGrabResult->GetErrorCode()
+        cerr << "Error: " << std::hex << ptrGrabResult->GetErrorCode()
              << std::dec << " " << ptrGrabResult->GetErrorDescription() << endl;
     }
 }

src/ImageEventHandler.h

@@ -25,9 +25,10 @@ class ImageEventHandler : public CBaslerUniversalImageEventHandler {
     unsigned long long int timeOffset;
     CPylonImage imgPylon;
     CImageFormatConverter formatConverter;
+    bool verbose;
 
 public:
-    ImageEventHandler ();
+    ImageEventHandler (bool inputVerbose);
 
     ~ImageEventHandler ();
 

src/ImageGrabber.cpp

@@ -2,10 +2,10 @@
  * Image Grabber
  * Application for grabbing images from Basler cameras using Pylon API.
  * @file            ImageGrabber.cpp
- * @version         1.0
+ * @version         2.0
  * @author          Daniel Konecny (xkonec75)
  * @organisation    Brno University of Technology - Faculty of Information Technologies
- * @date            02. 04. 2021
+ * @date            03. 04. 2021
  */
 
 #include <iostream>
@@ -47,7 +47,7 @@ ImageGrabber::ImageGrabber (ArgumentsParser parser) {
 	        new CSoftwareTriggerConfiguration, RegistrationMode_ReplaceAll, Cleanup_Delete);
 
 	    cameras[cameraIndex].RegisterImageEventHandler(
-	        new ImageEventHandler, RegistrationMode_Append, Cleanup_Delete);
+	        new ImageEventHandler(parser.IsVerbose()), RegistrationMode_Append, Cleanup_Delete);
 
         if (parser.IsVerbose()) {
             cout << "Using device " << cameras[cameraIndex].GetDeviceInfo().GetModelName() << endl;
@@ -66,13 +66,11 @@ ImageGrabber::ImageGrabber (ArgumentsParser parser) {
 	    // Enable time stamp chunks.
 	    cameras[cameraIndex].ChunkSelector.SetValue(Basler_UniversalCameraParams::ChunkSelector_Timestamp);
 	    cameras[cameraIndex].ChunkEnable.SetValue(true);
-
-        cout << cameras[cameraIndex].ResultingFrameRate.GetValue() << endl;
 	}
 }
 
 void ImageGrabber::Grab (ArgumentsParser parser) {
-    size_t imagesToTake = parser.GetImageCount();
+    int waitTime = parser.GetWaitTime();
 
     cameras.StartGrabbing(GrabStrategy_OneByOne, GrabLoop_ProvidedByInstantCamera);
 
@@ -81,28 +79,7 @@ void ImageGrabber::Grab (ArgumentsParser parser) {
             cameras[cameraIndex].WaitForFrameTriggerReady(100, TimeoutHandling_ThrowException);
             cameras[cameraIndex].ExecuteSoftwareTrigger();
         }
-        this_thread::sleep_for(chrono::milliseconds(10));
-        
-
-        /*
-    	// One possible sequential implementation of capturing images from two cameras.
-        if (cameraCount == 2) {
-            if (cameras[0].WaitForFrameTriggerReady(1000, TimeoutHandling_ThrowException)) {
-                cameras[0].ExecuteSoftwareTrigger();
-            }
-            if (cameras[1].WaitForFrameTriggerReady(1000, TimeoutHandling_ThrowException)) {
-                cameras[1].ExecuteSoftwareTrigger();
-            }
-        }
-        else if (cameraCount == 1) {
-            if (cameras[0].WaitForFrameTriggerReady(1000, TimeoutHandling_ThrowException)) {
-                cameras[0].ExecuteSoftwareTrigger();
-            }
-        }
-        else {
-            cerr << "Camera count " << cameraCount << " is not implemented." << endl;
-        }
-        */
+        this_thread::sleep_for(chrono::milliseconds(waitTime));
     }
 }
 

src/main.cpp

@@ -2,10 +2,10 @@
  * Image Grabber
  * Application for grabbing images from Basler cameras using Pylon API.
  * @file            main.cpp
- * @version         1.0
+ * @version         2.0
  * @author          Daniel Konecny (xkonec75)
  * @organisation    Brno University of Technology - Faculty of Information Technologies
- * @date            02. 04. 2021
+ * @date            03. 04. 2021
  */ 
 
 #include <iostream>