-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Add Profile" action is hard to cancel #4700
Comments
If we go for outside-click-closes then this should only apply to the first dialog, not the dialogs where you might click accidentally on the background after putting in some name or credentials already. |
the covering and tuning down of the sidebar is on purpose and should probably stay as is. tapping outside, as @Simon-Laux said is bad for subsequent dialogs, as you would lose quite some things. what will improve things already, is to have a regular "X"-close-button in the upper right corner, as usual for such dialogs. the "back navigation" is a bit misplaced there. also, "esc" does not work reliably for me (i always have to press the key two times on mac :) offtopic: i also somehow manage to remove the back button completely ... ![]() ... and the state of Delta got broken, i could not do anything, restarting Delta did not help. but restating the computer did :) |
#4898 removed the "Esc to close behavior. So, what we want is
Correct? |
sounds good! |
The text was updated successfully, but these errors were encountered: