Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Profile" action is hard to cancel #4700

Open
Nopey opened this issue Feb 24, 2025 · 4 comments
Open

"Add Profile" action is hard to cancel #4700

Nopey opened this issue Feb 24, 2025 · 4 comments
Labels
ui/ux UI/UX related issues

Comments

@Nopey
Copy link

Nopey commented Feb 24, 2025

  • Operating System: Windows 10
  • Delta Chat Version: v1.54.0-17-gecd0fef7-prepare-release-1.54.1
  • Expected behavior: either clicking in the background of the popup should close it (as it does for the "I Already Have a Profile" popup), or the popup's background should not cover the left column of profile buttons.
  • Actual behavior: the only way to dismiss the "Add Profile" popup is via the back arrow on its dialog.
  • Steps to reproduce the problem: Open Delta Chat. Have a user profile that is already logged in. Press the plus button on the profile switcher to open the "Add Profile" dialog. Click on the user profiles, click in the background, find that the "Add Profile" dialog covers them.
  • Screenshots:

Image

  • Logs: N/A
@Simon-Laux
Copy link
Member

If we go for outside-click-closes then this should only apply to the first dialog, not the dialogs where you might click accidentally on the background after putting in some name or credentials already.

@r10s
Copy link
Member

r10s commented Feb 24, 2025

the covering and tuning down of the sidebar is on purpose and should probably stay as is. tapping outside, as @Simon-Laux said is bad for subsequent dialogs, as you would lose quite some things.

what will improve things already, is to have a regular "X"-close-button in the upper right corner, as usual for such dialogs. the "back navigation" is a bit misplaced there.

also, "esc" does not work reliably for me (i always have to press the key two times on mac :)

offtopic: i also somehow manage to remove the back button completely ...

Image

... and the state of Delta got broken, i could not do anything, restarting Delta did not help. but restating the computer did :)

@WofWca
Copy link
Collaborator

WofWca commented Apr 1, 2025

#4898 removed the "Esc to close behavior.

So, what we want is

  • "Esc" to close the dialog, if we're on the first step of it. But I guess don't close it if there are no accounts.
  • Replace the "back" button with a "close" button on the first step of the dialog.

Correct?

@r10s
Copy link
Member

r10s commented Apr 1, 2025

sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux UI/UX related issues
Projects
None yet
Development

No branches or pull requests

4 participants