Skip to content

Be more defensive with completions_options #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dalmaer opened this issue Feb 6, 2023 · 0 comments
Open

Be more defensive with completions_options #103

dalmaer opened this issue Feb 6, 2023 · 0 comments
Labels
config

Comments

@dalmaer
Copy link
Collaborator

dalmaer commented Feb 6, 2023

Currently you either take the defaults or you grab the new object of config.

Be more defensive and for each key if one isn't there use the default.

But be careful, e.g. stop: '\n' don't want to bring that back because one wasn't passed in.
@dalmaer dalmaer added the config label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalmaer