diff --git a/Makefile b/Makefile index c6d92582..f37471cf 100644 --- a/Makefile +++ b/Makefile @@ -25,3 +25,12 @@ docs-prepare: .PHONY: docs docs: cd docs && hugo server + +.PHONY: mock +mock: + killgrave --config ./imposters/config.yml & + FF_MOCK_DATA=true go run . --debug + +.PHONY: mock-stop +mock-stop: + killall killgrave diff --git a/data/prapi.go b/data/prapi.go index 56ac1adb..358b36ec 100644 --- a/data/prapi.go +++ b/data/prapi.go @@ -23,28 +23,29 @@ type PullRequestData struct { Author struct { Login string } - AuthorAssociation string - UpdatedAt time.Time - CreatedAt time.Time - Url string - State string - Mergeable string - ReviewDecision string - Additions int - Deletions int - HeadRefName string - BaseRefName string - HeadRepository struct { + AuthorAssociation string + UpdatedAt time.Time + CreatedAt time.Time + Url string + State string + Mergeable string + ReviewDecision string + Additions int + Deletions int + HeadRefName string + BaseRefName string + HeadRepository struct { Name string } HeadRef struct { Name string } Repository Repository - Assignees Assignees `graphql:"assignees(first: 3)"` - Comments Comments `graphql:"comments(last: 5, orderBy: { field: UPDATED_AT, direction: DESC })"` - LatestReviews Reviews `graphql:"latestReviews(last: 3)"` - ReviewThreads ReviewThreads `graphql:"reviewThreads(last: 20)"` + Assignees Assignees `graphql:"assignees(first: 3)"` + Comments Comments `graphql:"comments(last: 5, orderBy: { field: UPDATED_AT, direction: DESC })"` + Reviews Reviews `graphql:"reviews(last: 3)"` + ReviewThreads ReviewThreads `graphql:"reviewThreads(last: 20)"` + ReviewRequests ReviewRequests `graphql:"reviewRequests(last: 10)"` IsDraft bool Commits Commits `graphql:"commits(last: 1)"` Labels PRLabels `graphql:"labels(first: 3)"` @@ -152,6 +153,13 @@ type ReviewThreads struct { } } +type ReviewRequests struct { + TotalCount int + Nodes []struct { + AsCodeOwner bool `graphql:"asCodeOwner"` + } +} + type PRLabel struct { Color string Name string diff --git a/data/repository.go b/data/repository.go index 16cb3b3e..6eee7587 100644 --- a/data/repository.go +++ b/data/repository.go @@ -1,7 +1,21 @@ package data +import ( + graphql "github.com/cli/shurcooL-graphql" +) + +type BranchProtectionRules struct { + Nodes []struct { + RequiredApprovingReviewCount int + RequiresApprovingReviews graphql.Boolean + RequiresCodeOwnerReviews graphql.Boolean + RequiresStatusChecks graphql.Boolean + } +} + type Repository struct { - Name string - NameWithOwner string - IsArchived bool + Name string + NameWithOwner string + IsArchived bool + BranchProtectionRules BranchProtectionRules `graphql:"branchProtectionRules(first: 1)"` } diff --git a/data/utils.go b/data/utils.go index 21d4961b..dbcdd78b 100644 --- a/data/utils.go +++ b/data/utils.go @@ -4,6 +4,7 @@ import ( "time" "github.com/charmbracelet/lipgloss" + "github.com/dlvhdr/gh-dash/v4/ui/theme" ) @@ -22,11 +23,19 @@ func IsStatusWaiting(status string) bool { status == "WAITING" } +func IsConclusionASkip(conclusion string) bool { + return conclusion == "SKIPPED" +} + func IsConclusionAFailure(conclusion string) bool { return conclusion == "FAILURE" || conclusion == "TIMED_OUT" || conclusion == "STARTUP_FAILURE" } -func GetAuthorRoleIcon(role string, theme theme.Theme) string { +func IsConclusionASuccess(conclusion string) bool { + return conclusion == "SUCCESS" +} + +func GetAuthorRoleIcon(role string, theme theme.Theme) string { // https://docs.github.com/en/graphql/reference/enums#commentauthorassociation switch role { case "FIRST_TIMER", "FIRST_TIME_CONTRIBUTOR", "NONE": diff --git a/imposters/pr.json b/imposters/pr.json index 13911e32..bfe26069 100644 --- a/imposters/pr.json +++ b/imposters/pr.json @@ -5,15 +5,16 @@ { "number": 31944, "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", + "body": "", "author": { "login": "lewis6991" }, "updatedAt": "2025-01-10T11:42:47Z", + "createdAt": "2025-01-09T11:42:47Z", "url": "https://github.com/neovim/neovim/pull/31944", "state": "OPEN", "mergeable": "MERGEABLE", - "reviewDecision": "", + "reviewDecision": "APPROVED", "additions": 60, "deletions": 28, "headRefName": "feat/optiontypemeta", @@ -45,116 +46,26 @@ "totalCount": 1 }, "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { + "totalCount": 2, "nodes": [ { - "color": "C5DEF5", - "name": "options" + "state": "APPROVED" }, { - "color": "0052CC", - "name": "ci:skip-news" + "state": "APPROVED" } ] }, - "mergeStateStatus": "BLOCKED" - }, - - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { + "reviewThreads": { "nodes": [] }, - "comments": { + "reviewRequests": { + "totalCount": 2, "nodes": [ { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" + "asCodeOwner": false } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] + ] }, "isDraft": true, "commits": { @@ -184,95 +95,6 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", @@ -289,95 +111,6 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", @@ -394,9130 +127,10 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ - { - "__typename": "CheckRun", - "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", - "checkSuite": { - "creator": { - "login": "" - }, - "workflowRun": { - "workflow": { - "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -9529,100 +142,10 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -9630,104 +153,14 @@ "workflowRun": { "workflow": { "name": "" - } - } - } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ + } + } + } + }, { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -9739,100 +172,10 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -9844,100 +187,11 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", "status": "COMPLETED", - "conclusion": "SUCCESS", + "conclusion": "FAILURE", "checkSuite": { "creator": { "login": "" @@ -9948,101 +202,12 @@ } } } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ + }, { "__typename": "CheckRun", "name": "CodeQL", "status": "COMPLETED", - "conclusion": "SUCCESS", + "conclusion": "SKIPPED", "checkSuite": { "creator": { "login": "" @@ -10053,14 +218,6 @@ } } } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } } ] } @@ -10084,54 +241,48 @@ "mergeStateStatus": "BLOCKED" }, { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", + "number": 2504, + "title": "feat(nvim): add dap.nvim", + "body": "", "author": { - "login": "lewis6991" + "login": "dlvhdr" }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", + "updatedAt": "2025-01-19T11:42:47Z", + "createdAt": "2025-01-18T11:42:47Z", + "url": "https://github.com/dlvhdr/dotfiles/pull/1", "state": "OPEN", "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", + "reviewDecision": "CHANGES_REQUESTED", + "additions": 120, + "deletions": 58, + "headRefName": "master", "baseRefName": "master", "headRepository": { - "name": "neovim" + "name": "dotfiles" }, "headRef": { - "name": "feat/optiontypemeta" + "name": "master" }, "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", + "name": "dotfiles", + "nameWithOwner": "dlvhdr/dotfiles", "isArchived": false }, "assignees": { "nodes": [] }, "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 + "nodes": [], + "totalCount": 0 }, "latestReviews": { - "nodes": [] + "totalCount": 1, + "nodes": [{ "state": "CHANGES_REQUESTED" }] }, "reviewThreads": { "nodes": [] }, - "isDraft": true, + "isDraft": false, "commits": { "nodes": [ { @@ -10141,7 +292,7 @@ }, "statusCheckRollup": { "contexts": { - "totalCount": 31, + "totalCount": 3, "nodes": [ { "__typename": "CheckRun", @@ -10159,95 +310,6 @@ } } }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } - } - ] - } - } - } - } - ] - }, - "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] - }, - "mergeStateStatus": "BLOCKED" - }, - { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", - "author": { - "login": "lewis6991" - }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", - "state": "OPEN", - "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", - "baseRefName": "master", - "headRepository": { - "name": "neovim" - }, - "headRef": { - "name": "feat/optiontypemeta" - }, - "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", - "isArchived": false - }, - "assignees": { - "nodes": [] - }, - "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 - }, - "latestReviews": { - "nodes": [] - }, - "reviewThreads": { - "nodes": [] - }, - "isDraft": true, - "commits": { - "nodes": [ - { - "commit": { - "deployments": { - "nodes": [] - }, - "statusCheckRollup": { - "contexts": { - "totalCount": 31, - "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", @@ -10265,11 +327,19 @@ } }, { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" + "__typename": "CheckRun", + "name": "CodeQL", + "status": "COMPLETED", + "conclusion": "SUCCESS", + "checkSuite": { + "creator": { + "login": "" + }, + "workflowRun": { + "workflow": { + "name": "" + } + } } } ] @@ -10280,68 +350,53 @@ ] }, "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] + "nodes": [] }, - "mergeStateStatus": "BLOCKED" + "mergeStateStatus": "CLEAN" }, { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", + "number": 2504, + "title": "feat(nvim): all green", + "body": "", "author": { - "login": "lewis6991" + "login": "dlvhdr" }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", + "updatedAt": "2025-01-19T11:42:47Z", + "createdAt": "2025-01-18T11:42:47Z", + "url": "https://github.com/dlvhdr/dotfiles/pull/1", "state": "OPEN", "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", + "reviewDecision": "APPROVED", + "additions": 120, + "deletions": 58, + "headRefName": "master", "baseRefName": "master", "headRepository": { - "name": "neovim" + "name": "dotfiles" }, "headRef": { - "name": "feat/optiontypemeta" + "name": "master" }, "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", + "name": "dotfiles", + "nameWithOwner": "dlvhdr/dotfiles", "isArchived": false }, "assignees": { "nodes": [] }, "comments": { - "nodes": [ - { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" - } - ], - "totalCount": 1 + "nodes": [], + "totalCount": 0 }, "latestReviews": { - "nodes": [] + "totalCount": 1, + "nodes": [{ "state": "APPROVED" }] }, "reviewThreads": { "nodes": [] }, - "isDraft": true, + "isDraft": false, "commits": { "nodes": [ { @@ -10351,7 +406,7 @@ }, "statusCheckRollup": { "contexts": { - "totalCount": 31, + "totalCount": 3, "nodes": [ { "__typename": "CheckRun", @@ -10368,14 +423,6 @@ } } } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } } ] } @@ -10385,68 +432,61 @@ ] }, "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] + "nodes": [] }, - "mergeStateStatus": "BLOCKED" + "mergeStateStatus": "CLEAN" }, { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", + "number": 2505, + "title": "feat(nvim): waiting", + "body": "", "author": { - "login": "lewis6991" + "login": "dlvhdr" }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", + "updatedAt": "2025-01-19T11:42:47Z", + "createdAt": "2025-01-18T11:42:47Z", + "url": "https://github.com/dlvhdr/dotfiles/pull/1", "state": "OPEN", "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", + "reviewDecision": "REVIEW_REQUIRED", + "additions": 120, + "deletions": 58, + "headRefName": "master", "baseRefName": "master", "headRepository": { - "name": "neovim" + "name": "dotfiles" }, "headRef": { - "name": "feat/optiontypemeta" + "name": "master" }, "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", + "name": "dotfiles", + "nameWithOwner": "dlvhdr/dotfiles", "isArchived": false }, "assignees": { "nodes": [] }, "comments": { + "nodes": [], + "totalCount": 0 + }, + "reviewRequests": { + "totalCount": 1, "nodes": [ { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" + "asCodeOwner": false } - ], - "totalCount": 1 + ] }, "latestReviews": { + "totalCount": 0, "nodes": [] }, "reviewThreads": { "nodes": [] }, - "isDraft": true, + "isDraft": false, "commits": { "nodes": [ { @@ -10456,13 +496,12 @@ }, "statusCheckRollup": { "contexts": { - "totalCount": 31, + "totalCount": 3, "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -10473,14 +512,6 @@ } } } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } } ] } @@ -10490,68 +521,61 @@ ] }, "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] + "nodes": [] }, - "mergeStateStatus": "BLOCKED" + "mergeStateStatus": "CLEAN" }, { - "number": 31944, - "title": "fix(options): better handling of empty values", - "body": "Problem:\n\nWhether an option is allowed to be empty isn't well defined and\nisn't properly checked.\n\nSolution:\n\n- For non-list string options, explicitly check the option value\n if it is empty.\n- Annotate non-list string options that can accept an empty value.\n - Adjust command completion to ignore the empty value.\n- Render values in Lua meta files", + "number": 2505, + "title": "feat(nvim): waiting on code owner", + "body": "", "author": { - "login": "lewis6991" + "login": "dlvhdr" }, - "updatedAt": "2025-01-10T11:42:47Z", - "url": "https://github.com/neovim/neovim/pull/31944", + "updatedAt": "2025-01-19T11:42:47Z", + "createdAt": "2025-01-18T11:42:47Z", + "url": "https://github.com/dlvhdr/dotfiles/pull/1", "state": "OPEN", "mergeable": "MERGEABLE", - "reviewDecision": "", - "additions": 60, - "deletions": 28, - "headRefName": "feat/optiontypemeta", + "reviewDecision": "REVIEW_REQUIRED", + "additions": 120, + "deletions": 58, + "headRefName": "master", "baseRefName": "master", "headRepository": { - "name": "neovim" + "name": "dotfiles" }, "headRef": { - "name": "feat/optiontypemeta" + "name": "master" }, "repository": { - "name": "neovim", - "nameWithOwner": "neovim/neovim", + "name": "dotfiles", + "nameWithOwner": "dlvhdr/dotfiles", "isArchived": false }, "assignees": { "nodes": [] }, "comments": { + "nodes": [], + "totalCount": 0 + }, + "reviewRequests": { + "totalCount": 1, "nodes": [ { - "author": { - "login": "zeertzjq" - }, - "body": "The addition of empty strings in `values` may lead to undesired behavior in cmdline completion:\r\n![Screenshot](https://github.com/user-attachments/assets/b770904b-5544-49a0-b815-31b51371d07c)\r\n\r\nNot selecting any entry already leads to a empty string, so there is now an redundant empty menu entry.", - "updatedAt": "2025-01-10T10:50:53Z" + "asCodeOwner": true } - ], - "totalCount": 1 + ] }, "latestReviews": { + "totalCount": 0, "nodes": [] }, "reviewThreads": { "nodes": [] }, - "isDraft": true, + "isDraft": false, "commits": { "nodes": [ { @@ -10561,13 +585,12 @@ }, "statusCheckRollup": { "contexts": { - "totalCount": 31, + "totalCount": 3, "nodes": [ { "__typename": "CheckRun", "name": "CodeQL", - "status": "COMPLETED", - "conclusion": "SUCCESS", + "status": "IN_PROGRESS", "checkSuite": { "creator": { "login": "" @@ -10578,14 +601,6 @@ } } } - }, - { - "__typename": "StatusContext", - "context": "", - "state": "", - "creator": { - "login": "" - } } ] } @@ -10595,21 +610,12 @@ ] }, "labels": { - "nodes": [ - { - "color": "C5DEF5", - "name": "options" - }, - { - "color": "0052CC", - "name": "ci:skip-news" - } - ] + "nodes": [] }, "mergeStateStatus": "BLOCKED" } ], - "issueCount": 22941, + "issueCount": 500, "pageInfo": { "hasNextPage": true, "startCursor": "Y3Vyc29yOjE=", diff --git a/ui/common/styles.go b/ui/common/styles.go index bced8818..124d927c 100644 --- a/ui/common/styles.go +++ b/ui/common/styles.go @@ -25,6 +25,7 @@ type CommonStyles struct { MainTextStyle lipgloss.Style FooterStyle lipgloss.Style ErrorStyle lipgloss.Style + DraftGlyph string WaitingGlyph string FailureGlyph string SuccessGlyph string @@ -46,7 +47,7 @@ func BuildStyles(theme theme.Theme) CommonStyles { MaxHeight(FooterHeight) s.WaitingGlyph = lipgloss.NewStyle(). - Foreground(theme.FaintText). + Foreground(theme.WarningText). Render(constants.WaitingIcon) s.FailureGlyph = lipgloss.NewStyle(). Foreground(theme.ErrorText). @@ -57,6 +58,9 @@ func BuildStyles(theme theme.Theme) CommonStyles { s.CommentGlyph = lipgloss.NewStyle(). Foreground(theme.PrimaryText). Render(constants.CommentIcon) + s.DraftGlyph = lipgloss.NewStyle(). + Foreground(theme.PrimaryText). + Render(constants.DraftIcon) return s } diff --git a/ui/components/branch/branch.go b/ui/components/branch/branch.go index 853862bd..c8f1c329 100644 --- a/ui/components/branch/branch.go +++ b/ui/components/branch/branch.go @@ -42,7 +42,7 @@ func (b *Branch) renderReviewStatus() string { reviewCellStyle = reviewCellStyle.Foreground( b.Ctx.Theme.ErrorText, ) - return reviewCellStyle.Render("󰌑") + return reviewCellStyle.Render("") } return reviewCellStyle.Render(b.Ctx.Styles.Common.WaitingGlyph) diff --git a/ui/components/pr/pr.go b/ui/components/pr/pr.go index f615d8ca..fe5ccf27 100644 --- a/ui/components/pr/pr.go +++ b/ui/components/pr/pr.go @@ -16,10 +16,10 @@ import ( ) type PullRequest struct { - Ctx *context.ProgramContext - Data *data.PullRequestData - Branch git.Branch - Columns []table.Column + Ctx *context.ProgramContext + Data *data.PullRequestData + Branch git.Branch + Columns []table.Column ShowAuthorIcon bool } @@ -43,10 +43,10 @@ func (pr *PullRequest) renderReviewStatus() string { reviewCellStyle = reviewCellStyle.Foreground( pr.Ctx.Theme.ErrorText, ) - return reviewCellStyle.Render("󰌑") + return reviewCellStyle.Render("") } - if pr.Data.LatestReviews.TotalCount > 0 { + if pr.Data.Reviews.TotalCount > 0 { return reviewCellStyle.Render(pr.Ctx.Styles.Common.CommentGlyph) } diff --git a/ui/components/prsidebar/activity.go b/ui/components/prsidebar/activity.go index 68fb256a..7448d5d7 100644 --- a/ui/components/prsidebar/activity.go +++ b/ui/components/prsidebar/activity.go @@ -58,7 +58,7 @@ func (m *Model) renderActivity() string { }) } - for _, review := range m.pr.Data.LatestReviews.Nodes { + for _, review := range m.pr.Data.Reviews.Nodes { renderedReview, err := m.renderReview(review, markdownRenderer) if err != nil { continue diff --git a/ui/components/prsidebar/checks.go b/ui/components/prsidebar/checks.go index 92d485d3..a046be55 100644 --- a/ui/components/prsidebar/checks.go +++ b/ui/components/prsidebar/checks.go @@ -1,121 +1,318 @@ package prsidebar import ( + "fmt" + "math" "strings" "github.com/charmbracelet/lipgloss" + "github.com/dlvhdr/gh-dash/v4/data" ) -func (sidebar *Model) renderChecks() string { - title := sidebar.ctx.Styles.Common.MainTextStyle.MarginBottom(1).Underline(true).Render(" Checks") +type checkSectionStatus int - commits := sidebar.pr.Data.Commits.Nodes - if len(commits) == 0 { - return "" - } +const ( + statusSuccess checkSectionStatus = iota + statusFailure + statusWaiting +) - var checks []string - for _, review := range sidebar.pr.Data.LatestReviews.Nodes { - checks = append(checks, sidebar.renderReviewHeader(review)) - } +func (m *Model) renderChecks() string { + header := m.ctx.Styles.Common.MainTextStyle.MarginBottom(1).Underline(true).Render(" Checks") + w := m.getIndentedContentWidth() - lastCommit := commits[0] - for _, node := range lastCommit.Commit.StatusCheckRollup.Contexts.Nodes { - if node.Typename == "CheckRun" { - checkRun := node.CheckRun - renderedStatus := sidebar.renderCheckRunConclusion(checkRun) - name := renderCheckRunName(checkRun) - checks = append(checks, lipgloss.JoinHorizontal(lipgloss.Top, renderedStatus, " ", name)) - } else if node.Typename == "StatusContext" { - statusContext := node.StatusContext - status := sidebar.renderStatusContextConclusion(statusContext) - checks = append(checks, lipgloss.JoinHorizontal(lipgloss.Top, status, " ", renderStatusContextName(statusContext))) - } - } + review, rStatus := m.viewReviewStatus() + checks, cStatus := m.viewChecksStatus() + merge, mStatus := m.viewMergeStatus() - if len(checks) == 0 { - return lipgloss.JoinVertical( - lipgloss.Left, - title, - lipgloss.NewStyle(). - Italic(true). - PaddingLeft(2). - Width(sidebar.getIndentedContentWidth()). - Render("No checks to display..."), - ) + borderColor := m.ctx.Theme.FaintBorder + if rStatus == statusFailure || cStatus == statusFailure || mStatus == statusFailure { + borderColor = m.ctx.Theme.ErrorText + } else if rStatus == statusSuccess && cStatus == statusSuccess && mStatus == statusSuccess { + borderColor = m.ctx.Theme.SuccessText } - renderedChecks := lipgloss.JoinVertical(lipgloss.Left, checks...) - return lipgloss.JoinVertical( - lipgloss.Left, - title, - lipgloss.NewStyle().PaddingLeft(2).Width(sidebar.getIndentedContentWidth()).Render(renderedChecks), + box := lipgloss.NewStyle().Border(lipgloss.RoundedBorder()).BorderForeground(borderColor).Width(w) + + return lipgloss.JoinVertical(lipgloss.Left, + header, + box.Render(lipgloss.JoinVertical(lipgloss.Left, review, checks, merge)), ) + } -func (m *Model) renderCheckRunConclusion(checkRun data.CheckRun) string { - conclusionStr := string(checkRun.Conclusion) - if data.IsStatusWaiting(string(checkRun.Status)) { - return m.ctx.Styles.Common.WaitingGlyph +func (m *Model) viewChecksStatus() (string, checkSectionStatus) { + checks := "" + stats := m.getChecksStats() + var icon, title string + var status checkSectionStatus + + statStrs := make([]string, 0) + if stats.failed > 0 { + icon = m.ctx.Styles.Common.FailureGlyph + title = "Some checks were not successful" + status = statusFailure + } else if stats.inProgress > 0 { + icon = m.ctx.Styles.Common.WaitingGlyph + title = "Some checks haven't completed yet" + status = statusWaiting + } else if stats.succeeded > 0 { + icon = m.ctx.Styles.Common.SuccessGlyph + title = "All checks have passed" + status = statusSuccess } - if data.IsConclusionAFailure(conclusionStr) { - return m.ctx.Styles.Common.FailureGlyph + if stats.failed > 0 { + statStrs = append(statStrs, fmt.Sprintf("%d failing", stats.failed)) + } + if stats.inProgress > 0 { + statStrs = append(statStrs, fmt.Sprintf("%d in progress", stats.inProgress)) } + if stats.skipped > 0 { + statStrs = append(statStrs, fmt.Sprintf("%d skipped", stats.skipped)) + } + if stats.succeeded > 0 { + statStrs = append(statStrs, fmt.Sprintf("%d successful", stats.succeeded)) + } + if title != "" { + checksBar := m.viewChecksBar() + checksBottom := lipgloss.JoinVertical(lipgloss.Left, strings.Join(statStrs, ", "), checksBar) + checks = m.viewCheckCategory(icon, title, checksBottom, false) + } + return checks, status +} - return m.ctx.Styles.Common.SuccessGlyph +func (m *Model) viewMergeStatus() (string, checkSectionStatus) { + var icon, title, subtitle string + var status checkSectionStatus + numReviewOwners := m.numRequestedReviewOwners() + if m.pr.Data.MergeStateStatus == "CLEAN" || m.pr.Data.MergeStateStatus == "UNSTABLE" { + icon = m.ctx.Styles.Common.SuccessGlyph + title = "No conflicts with base branch" + subtitle = "Changes can be cleanly merged" + status = statusSuccess + } else if m.pr.Data.IsDraft { + icon = m.ctx.Styles.Common.DraftGlyph + title = "This pull request is still a work in progress" + subtitle = "Draft pull requests cannot be merged" + status = statusWaiting + } else if m.pr.Data.MergeStateStatus == "BLOCKED" { + icon = m.ctx.Styles.Common.FailureGlyph + title = "Merging is blocked" + if numReviewOwners > 0 { + subtitle = "Waiting on code owner review" + } + status = statusFailure + } else if m.pr.Data.Mergeable == "CONFLICTING" { + icon = m.ctx.Styles.Common.FailureGlyph + title = "This branch has conflicts that must be resolved" + status = statusFailure + if m.pr.Data.MergeStateStatus == "CLEAN" { + subtitle = "Changes can be cleanly merged" + } + } + return m.viewCheckCategory(icon, title, subtitle, true), status } -func (m *Model) renderStatusContextConclusion(statusContext data.StatusContext) string { - conclusionStr := string(statusContext.State) - if data.IsStatusWaiting(conclusionStr) { - return m.ctx.Styles.Common.WaitingGlyph +func (m *Model) viewReviewStatus() (string, checkSectionStatus) { + pr := m.pr + if pr.Data == nil { + return "", statusWaiting } - if data.IsConclusionAFailure(conclusionStr) { - return m.ctx.Styles.Common.FailureGlyph + var icon, title, subtitle string + var status checkSectionStatus + numReviewOwners := m.numRequestedReviewOwners() + + numApproving, numChangesRequested, numPending, numCommented := 0, 0, 0, 0 + for _, node := range pr.Data.Reviews.Nodes { + if node.State == "APPROVED" { + numApproving++ + } else if node.State == "CHANGES_REQUESTED" { + numChangesRequested++ + } else if node.State == "PENDING" { + numPending++ + } else if node.State == "COMMENTED" { + numCommented++ + } } - return m.ctx.Styles.Common.SuccessGlyph + if pr.Data.ReviewDecision == "APPROVED" { + icon = m.ctx.Styles.Common.SuccessGlyph + title = "Changes approved" + subtitle = fmt.Sprintf("%d approving reviews", numApproving) + status = statusSuccess + } else if pr.Data.ReviewDecision == "CHANGES_REQUESTED" { + icon = m.ctx.Styles.Common.FailureGlyph + title = "Changes requested" + subtitle = fmt.Sprintf("%d requested changes", numChangesRequested) + status = statusFailure + } else if pr.Data.ReviewDecision == "REVIEW_REQUIRED" { + icon = pr.Ctx.Styles.Common.WaitingGlyph + title = "Review Required" + + branchRules := m.pr.Data.Repository.BranchProtectionRules.Nodes + if len(branchRules) > 0 && branchRules[0].RequiresCodeOwnerReviews && numApproving < 1 { + subtitle = "Code owner review required" + status = statusFailure + } else if numApproving < numReviewOwners { + subtitle = "Code owner review required" + status = statusFailure + } else if len(branchRules) > 0 && numApproving < branchRules[0].RequiredApprovingReviewCount { + subtitle = fmt.Sprintf("Need %d more approval", branchRules[0].RequiredApprovingReviewCount-numApproving) + status = statusWaiting + } else if numCommented > 0 { + subtitle = fmt.Sprintf("%d reviewers left comments", numCommented) + status = statusWaiting + } + } + + return m.viewCheckCategory(icon, title, subtitle, false), status } -func renderCheckRunName(checkRun data.CheckRun) string { - var parts []string - creator := strings.TrimSpace(string(checkRun.CheckSuite.Creator.Login)) - if creator != "" { - parts = append(parts, creator) +func (m *Model) viewCheckCategory(icon, title, subtitle string, isLast bool) string { + w := m.getIndentedContentWidth() + part := lipgloss.NewStyle(). + Border(lipgloss.NormalBorder(), false, false, !isLast, false). + BorderForeground(m.ctx.Theme.FaintBorder). + Width(w). + Padding(1) + + sTitle := lipgloss.NewStyle().Bold(true) + sSub := lipgloss.NewStyle().Foreground(m.ctx.Theme.FaintText) + + category := lipgloss.JoinHorizontal(lipgloss.Top, icon, " ", sTitle.Render(title)) + + if subtitle != "" { + category = lipgloss.JoinVertical(lipgloss.Left, category, sSub.MarginLeft(2).Render(subtitle)) } + return part.Render(category) +} - workflow := strings.TrimSpace(string(checkRun.CheckSuite.WorkflowRun.Workflow.Name)) - if workflow != "" { - parts = append(parts, workflow) +func (m *Model) viewChecksBar() string { + w := m.getIndentedContentWidth() - 4 + stats := m.getChecksStats() + total := float64(stats.failed + stats.skipped + stats.succeeded + stats.inProgress) + numSections := 0 + if stats.failed > 0 { + numSections++ + } + if stats.inProgress > 0 { + numSections++ } + if stats.skipped > 0 { + numSections++ + } + if stats.succeeded > 0 { + numSections++ + } + // subtract num of spacers + w -= numSections - 1 - name := strings.TrimSpace(string(checkRun.Name)) - if name != "" { - parts = append(parts, name) + sections := make([]string, 0) + if stats.failed > 0 { + failWidth := int(math.Floor((float64(stats.failed) / total) * float64(w))) + sections = append(sections, lipgloss.NewStyle().Width(failWidth).Foreground(m.ctx.Theme.ErrorText).Height(1).Render(strings.Repeat("▃", failWidth))) + } + if stats.inProgress > 0 { + ipWidth := int(math.Floor((float64(stats.inProgress) / total) * float64(w))) + sections = append(sections, lipgloss.NewStyle().Width(ipWidth).Foreground(m.ctx.Theme.WarningText).Height(1).Render(strings.Repeat("▃", ipWidth))) + } + if stats.skipped > 0 { + skipWidth := int(math.Floor((float64(stats.skipped) / total) * float64(w))) + sections = append(sections, lipgloss.NewStyle().Width(skipWidth).Foreground(m.ctx.Theme.FaintText).Height(1).Render(strings.Repeat("▃", skipWidth))) + } + if stats.succeeded > 0 { + succWidth := int(math.Floor((float64(stats.succeeded) / total) * float64(w))) + sections = append(sections, lipgloss.NewStyle().Width(succWidth).Foreground(m.ctx.Theme.SuccessText).Height(1).Render(strings.Repeat("▃", succWidth))) } - return lipgloss.JoinHorizontal( - lipgloss.Top, - strings.Join(parts, "/"), - ) + return strings.Join(sections, " ") +} + +// func renderCheckRunName(checkRun data.CheckRun) string { +// var parts []string +// creator := strings.TrimSpace(string(checkRun.CheckSuite.Creator.Login)) +// if creator != "" { +// parts = append(parts, creator) +// } +// +// workflow := strings.TrimSpace(string(checkRun.CheckSuite.WorkflowRun.Workflow.Name)) +// if workflow != "" { +// parts = append(parts, workflow) +// } +// +// name := strings.TrimSpace(string(checkRun.Name)) +// if name != "" { +// parts = append(parts, name) +// } +// +// return lipgloss.JoinHorizontal( +// lipgloss.Top, +// strings.Join(parts, "/"), +// ) +// } + +// func renderStatusContextName(statusContext data.StatusContext) string { +// var parts []string +// creator := strings.TrimSpace(string(statusContext.Creator.Login)) +// if creator != "" { +// parts = append(parts, creator) +// } +// +// context := strings.TrimSpace(string(statusContext.Context)) +// if context != "" && context != "/" { +// parts = append(parts, context) +// } +// return lipgloss.JoinHorizontal( +// lipgloss.Top, +// strings.Join(parts, "/"), +// ) +// } + +type checksStats struct { + succeeded int + failed int + skipped int + inProgress int } -func renderStatusContextName(statusContext data.StatusContext) string { - var parts []string - creator := strings.TrimSpace(string(statusContext.Creator.Login)) - if creator != "" { - parts = append(parts, creator) +func (m *Model) getChecksStats() checksStats { + var res checksStats + commits := m.pr.Data.Commits.Nodes + if len(commits) == 0 { + return res } - context := strings.TrimSpace(string(statusContext.Context)) - if context != "" && context != "/" { - parts = append(parts, context) + lastCommit := commits[0] + for _, node := range lastCommit.Commit.StatusCheckRollup.Contexts.Nodes { + if node.Typename == "CheckRun" { + checkRun := node.CheckRun + conclusion := string(checkRun.Conclusion) + if data.IsStatusWaiting(string(checkRun.Status)) { + res.inProgress++ + } else if data.IsConclusionAFailure(conclusion) { + res.failed++ + } else if data.IsConclusionASkip(conclusion) { + res.skipped++ + } else if data.IsConclusionASuccess(conclusion) { + res.succeeded++ + } + } } - return lipgloss.JoinHorizontal( - lipgloss.Top, - strings.Join(parts, "/"), - ) + + return res +} + +func (m *Model) numRequestedReviewOwners() int { + numOwners := 0 + + for _, node := range m.pr.Data.ReviewRequests.Nodes { + if node.AsCodeOwner { + numOwners++ + } + } + + return numOwners }