#1: encode double quotes to ensure the attribute is correct xml when printed

Author: proggeler

src/Node/Attribute.php

@@ -27,6 +27,10 @@ public function __toString(): string
     {
         $name = ($this->prefix ? $this->prefix . ':' : '') . $this->localName;
 
-        return sprintf('%s="%s"', $name, htmlentities($this->value, ENT_XML1 | ENT_SUBSTITUTE, 'UTF-8', false));
+        return sprintf(
+            '%s="%s"',
+            $name,
+            htmlentities($this->value, ENT_XML1 | ENT_SUBSTITUTE | ENT_COMPAT, 'UTF-8', false)
+        );
     }
 }

tests/Node/AttributeTest.php

@@ -41,6 +41,12 @@ public function provideAttribute(): iterable
                 'foo',
                 'ns1:foo="bar"'
             ],
+            'attribute with quote' => [
+                new Attribute('foo', 'bar"'),
+                '',
+                'foo',
+                'foo="bar""'
+            ],
         ];
     }
 }