Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] sdk-task.ps1: Update the xcopy-msbuild version to 17.12.0 #15416

Draft
wants to merge 1 commit into
base: release/8.0
Choose a base branch
from

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Jan 14, 2025

Signing validation started failing in the maintenance-packages repo since we took this arcade codeflow.

The error is:

Could not resolve SDK "Microsoft.NET.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
Version 8.0.403 of the .NET SDK requires at least version 17.9.5 of MSBuild. The current available version of MSBuild is 17.8.1.47607. Change the .NET SDK specified in global.json to an older version that requires the MSBuild version currently available.
The NuGetSdkResolver did not resolve this SDK because there was no version specified in the project or global.json.
MSB4276: The default SDK resolver failed to resolve SDK "Microsoft.NET.Sdk" because directory "d:\a\_work\1\s\.tools\msbuild\17.8.1-2\tools\MSBuild\Sdks\Microsoft.NET.Sdk\Sdk" did not exist.
error MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.

We are consuming the sdk version 8.0.403 in global.json.

The root cause is that eng/common/sdk-task.ps1 hardcodes the xcopy-msbuild version to 17.8.1-2 when not found in global.json.

The workaround would be to set the tools->xcopy-msbuild version to 17.12.0 in global.json. Edit: It didn't work, a test in the official azdo repo shows the signing failure is still happening.

The fix is to update the hardcoded version to the supported one.

To double check:

@carlossanlop
Copy link
Member Author

Although the CI passed, the failure is still there. I tested this in the official azdo repo with signing enabled and the failure is still showing up .

@dotnet/dnceng I got some help from @rainersigwald and it looks like Arcade 8 does not support SDK 8.0.4xx but it should.

Who would be the right person to help with the update? It's actively blocking maintenance-packages, as it uses arcade 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant