fix: remove scala-tools.org from pom.xml due to shutdown of scala-tools.org repository (#1201)

* fix: remove scala-tools.org

* fix: scala mismatch version

* fix: add wait for DaemonWorker Listen

* fix: rollback logerror

* fix: rollback logerror

* fix: simplfied listenerReadyTcs

---------

Co-authored-by: lane <lane@bridgewell.com>

Author: laneser

benchmark/scala/pom.xml

@@ -7,25 +7,11 @@
   <inceptionYear>2019</inceptionYear>
   <properties>
     <encoding>UTF-8</encoding>
-    <scala.version>2.11.8</scala.version>
+    <scala.version>2.11.12</scala.version>
     <scala.binary.version>2.11</scala.binary.version>
     <spark.version>2.4.4</spark.version>
   </properties>
 
-  <pluginRepositories>
-    <pluginRepository>
-      <id>scala</id>
-      <name>Scala Tools</name>
-      <url>http://scala-tools.org/repo-releases/</url>
-      <releases>
-        <enabled>true</enabled>
-      </releases>
-      <snapshots>
-        <enabled>false</enabled>
-      </snapshots>
-    </pluginRepository>
-  </pluginRepositories>
-
   <dependencies>
     <dependency>
       <groupId>org.scala-lang</groupId>

src/csharp/Microsoft.Spark.Worker.UnitTest/DaemonWorkerTests.cs

@@ -25,22 +25,23 @@ public DaemonWorkerTests()
 
         [Theory]
         [MemberData(nameof(TestData.VersionData), MemberType = typeof(TestData))]
-        public void TestsDaemonWorkerTaskRunners(string version)
+        public async void TestsDaemonWorkerTaskRunners(string version)
         {
             ISocketWrapper daemonSocket = SocketFactory.CreateSocket();
-            
+
             int taskRunnerNumber = 2;
             var typedVersion = new Version(version);
             var daemonWorker = new DaemonWorker(typedVersion);
-            
-            Task.Run(() => daemonWorker.Run(daemonSocket));
+
+            var _dummyTask = Task.Run(() => daemonWorker.Run(daemonSocket));
+            await daemonWorker.WaitForListenerReadyAsync();
 
             var clientSockets = new List<ISocketWrapper>();
             for (int i = 0; i < taskRunnerNumber; ++i)
             {
                 CreateAndVerifyConnection(daemonSocket, clientSockets, typedVersion);
             }
-            
+
             Assert.Equal(taskRunnerNumber, daemonWorker.CurrentNumTaskRunners);
         }
 

src/csharp/Microsoft.Spark.Worker/DaemonWorker.cs

@@ -9,6 +9,7 @@
 using System.Linq;
 using System.Net;
 using System.Threading;
+using System.Threading.Tasks;
 using Microsoft.Spark.Interop.Ipc;
 using Microsoft.Spark.Network;
 using Microsoft.Spark.Services;
@@ -46,6 +47,8 @@ internal sealed class DaemonWorker
 
         private readonly Version _version;
 
+        private readonly TaskCompletionSource<bool> _listenerReadyTcs = new TaskCompletionSource<bool>();
+
         internal DaemonWorker(Version version)
         {
             _version = version;
@@ -73,6 +76,7 @@ internal void Run(ISocketWrapper listener)
             try
             {
                 listener.Listen();
+                _listenerReadyTcs.TrySetResult(true);
 
                 // Communicate the server port back to the Spark using standard output.
                 Stream outputStream = Console.OpenStandardOutput();
@@ -100,6 +104,11 @@ internal void Run(ISocketWrapper listener)
             }
         }
 
+        internal Task WaitForListenerReadyAsync()
+        {
+            return _listenerReadyTcs.Task;
+        }
+
         /// <summary>
         /// Starts listening to any connection from JVM.
         /// </summary>

src/scala/microsoft-spark-2-4/pom.xml

@@ -10,7 +10,7 @@
   <inceptionYear>2019</inceptionYear>
   <properties>
     <encoding>UTF-8</encoding>
-    <scala.version>2.11.8</scala.version>
+    <scala.version>2.11.12</scala.version>
     <scala.binary.version>2.11</scala.binary.version>
     <spark.version>2.4.4</spark.version>
   </properties>

src/scala/pom.xml

@@ -18,18 +18,4 @@
     <module>microsoft-spark-3-3</module>
     <module>microsoft-spark-3-5</module>
   </modules>
-
-  <pluginRepositories>
-    <pluginRepository>
-      <id>scala</id>
-      <name>Scala Tools</name>
-      <url>http://scala-tools.org/repo-releases/</url>
-      <releases>
-        <enabled>true</enabled>
-      </releases>
-      <snapshots>
-        <enabled>false</enabled>
-      </snapshots>
-    </pluginRepository>
-  </pluginRepositories>
 </project>