Skip to content

Commit 6adf24a

Browse files
author
FSadrieh
committed
Added tests
1 parent f2a98ac commit 6adf24a

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

evap/staff/tests/test_views.py

+19
Original file line numberDiff line numberDiff line change
@@ -1931,6 +1931,25 @@ def test_create_exam_evaluation(self):
19311931
self.assertEqual(exam_evaluation.participants.count(), self.evaluation.participants.count())
19321932
self.assertEqual(exam_evaluation.weight, 1)
19331933

1934+
def test_exam_evaluation_for_single_result(self):
1935+
self.evaluation.is_single_result = True
1936+
self.evaluation.save()
1937+
self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
1938+
self.assertFalse(self.evaluation.has_exam)
1939+
1940+
def test_exam_evaluation_for_already_existing_exam_evaluation(self):
1941+
baker.make(Evaluation, course=self.course, name_en="Exam", name_de="Klausur")
1942+
self.assertTrue(self.evaluation.has_exam)
1943+
self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
1944+
1945+
def test_exam_evaluation_with_wrong_date(self):
1946+
self.evaluation.vote_start_datetime = datetime.datetime.now() + datetime.timedelta(days=100)
1947+
self.evaluation.vote_end_date = datetime.date.today() + datetime.timedelta(days=150)
1948+
self.evaluation.save()
1949+
1950+
self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
1951+
self.assertFalse(self.evaluation.has_exam)
1952+
19341953

19351954
class TestCourseCopyView(WebTestStaffMode):
19361955
@classmethod

evap/staff/views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1062,7 +1062,7 @@ def create_exam_evaluation(request):
10621062
if evaluation.is_single_result:
10631063
raise SuspiciousOperation("Creating an exam evaluation for a single result evaluation is not allowed")
10641064

1065-
if evaluation.course.evaluations.filter(name_de="Klausur", name_en="Exam").exists():
1065+
if evaluation.has_exam:
10661066
raise SuspiciousOperation("An exam evaluation already exists for this course.")
10671067

10681068
evaluation_end_date = exam_date - timedelta(days=1)

0 commit comments

Comments
 (0)