From ddb0ab02be969c983c36f4fe82e10d33208cb888 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antti=20M=C3=A4ki?= Date: Wed, 31 Jan 2024 13:29:40 +0200 Subject: [PATCH] Fix race condition when setting doorstop Use GameInstruction to only set vanillaLaunchArgs, and to not touch the doorstopTarget, which should be set by the GameRunningProvider. This way the doorstopTarget value shown on modal will actually match the values that are used when the game is launched either as vanilla or as modded by the GameRunner instance. --- src/pages/Manager.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/pages/Manager.vue b/src/pages/Manager.vue index bba8bce1d..7261339b7 100644 --- a/src/pages/Manager.vue +++ b/src/pages/Manager.vue @@ -454,8 +454,7 @@ import CategoryFilterModal from '../components/modals/CategoryFilterModal.vue'; showLaunchParameters() { if (this.contextProfile !== null) { - GameInstructions.getInstructionsForGame(this.activeGame, this.contextProfile).then(async instructions => { - this.doorstopTarget = instructions.moddedParameters; + GameInstructions.getInstructionsForGame(this.activeGame, this.contextProfile).then(instructions => { this.vanillaLaunchArgs = instructions.vanillaParameters; });