Merge pull request #41 from educorvi/develop

fix type guard for ArrayLike

Author: neferin12

common/changes/@educorvi/rita/develop_2024-10-21-09-17.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@educorvi/rita",
+      "comment": "fix type guard for ArrayLike",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@educorvi/rita"
+}

rita-core/src/Assertions.ts

@@ -54,11 +54,11 @@ export function assertDuration(
     }
 }
 
-export function hasLength(
+export function assertArrayLike(
     value: unknown,
     context: Formula
 ): asserts value is unknown & { length: number } {
-    if (!value || !value.hasOwnProperty('length')) {
+    if (!value?.hasOwnProperty('length')) {
         throw new HasNoLengthError(context, value);
     }
 }

rita-core/src/logicElements/Macro.ts

@@ -1,6 +1,6 @@
 import { Formula, FormulaResults } from './Formula';
 import { Atom } from './Atom';
-import { hasLength } from '../Assertions';
+import { assertArrayLike } from '../Assertions';
 
 export class Macro extends Formula {
     /** Indicates the type of this atom **/
@@ -21,7 +21,7 @@ export class Macro extends Formula {
                 return new Date();
             case 'length':
                 const ar = await this.array?.evaluate(data);
-                hasLength(ar, this);
+                assertArrayLike(ar, this);
                 return ar.length;
         }
     }