Skip to content

Commit 05abcf8

Browse files
authored
Remove compilesdk validation (#292)
* Removing androidx libs version constraints * Updating tests * Updating sample app compileSdk version * Updating notice files * Updated the changelog
1 parent 561606a commit 05abcf8

File tree

8 files changed

+23
-23
lines changed

8 files changed

+23
-23
lines changed

CHANGELOG.asciidoc

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ ${next_release_notes}
3030
==== ${version} - ${release_date}
3131

3232
[float]
33-
===== Features
33+
===== Bug fixes
3434

35-
* New feature: {pull}000[#000]
35+
* Removing strict version constraint that prevented enforcing compileSdk > 33: {pull}292[#292]
3636
////
3737
3838
[[release-notes-0.15.0]]

NOTICE

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Copyright 2018-2022 Elasticsearch B.V.
55

66
This product includes software licensed under the 'Apache License Version 2.0' license from the following sources:
77

8-
- Android Lifecycle Process (https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.1)
8+
- Android Lifecycle Process (https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.2)
99
- Android Support Library Annotations (https://developer.android.com/jetpack/androidx/releases/annotation#1.4.0)
1010
- Byte Buddy (without dependencies)
1111
- Byte Buddy Gradle plugin

android-sdk/build.gradle

-14
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,4 @@ dependencies {
5757
compileOnly 'co.elastic.apm.compile:processor'
5858
testImplementation libs.bundles.mocking
5959
testImplementation libs.junit
60-
61-
// To avoid enforcing compileSdk > 33:
62-
constraints {
63-
add("implementation", "androidx.navigation:navigation-fragment") {
64-
version {
65-
strictly("2.6.0")
66-
}
67-
}
68-
add("implementation", "androidx.core:core") {
69-
version {
70-
strictly("1.10.1")
71-
}
72-
}
73-
}
7460
}
+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
dependencies.hash=F58F6A39BDAD2A7E96BD4C0924CF4A0C
1+
dependencies.hash=77B4570CA3D2C0BA9C3541561D0679C0

android-sdk/src/main/resources/META-INF/NOTICE

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Copyright 2018-2022 Elasticsearch B.V.
55

66
This product includes software licensed under the 'Apache License Version 2.0' license from the following sources:
77

8-
- Android Lifecycle Process (https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.1)
8+
- Android Lifecycle Process (https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.2)
99
- com.github.instacart.truetime-android:library:3.5
1010
- okhttp (https://square.github.io/okhttp/)
1111
- OpenTelemetry Android (https://github.com/open-telemetry/opentelemetry-android)

android-test/app/build.gradle

+15-1
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,26 @@ dependencies {
6666
testImplementation "io.opentelemetry:opentelemetry-exporter-otlp:1.28.0"
6767
testImplementation "org.mockito:mockito-core:$mockito_version"
6868
testImplementation "org.mockito:mockito-inline:$mockito_version"
69-
testImplementation 'org.robolectric:robolectric:4.11.1'
69+
testImplementation 'org.robolectric:robolectric:4.12.1'
7070
testImplementation "com.squareup.okhttp3:mockwebserver:$mockwebserver_version"
7171
androidTestImplementation "androidx.test:core:1.5.0"
7272
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
7373
androidTestImplementation 'androidx.test:runner:1.5.2'
7474
androidTestImplementation "androidx.test.espresso:espresso-core:$espresso_version"
7575
androidTestImplementation "androidx.test.espresso:espresso-contrib:$espresso_version"
7676
androidTestImplementation "com.squareup.okhttp3:mockwebserver:$mockwebserver_version"
77+
78+
// To avoid enforcing compileSdk > 33:
79+
constraints {
80+
add("implementation", "androidx.navigation:navigation-fragment") {
81+
version {
82+
strictly("2.6.0")
83+
}
84+
}
85+
add("implementation", "androidx.core:core") {
86+
version {
87+
strictly("1.10.1")
88+
}
89+
}
90+
}
7791
}

android-test/plugin-test/src/test/java/co/elastic/apm/android/plugin/testutils/BaseFunctionalTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ private void ensureExistingParentDir(File file) {
134134
}
135135

136136
protected int getAndroidCompileSdk() {
137-
return 33;
137+
return 34;
138138
}
139139

140140
protected String getAndroidAppId() {

sample-app/app/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ plugins {
66

77
android {
88
namespace 'co.elastic.apm.android.sample'
9-
compileSdk 33
9+
compileSdk 34
1010

1111
defaultConfig {
1212
applicationId "co.elastic.apm.android.sample"
1313
minSdk 26
14-
targetSdk 33
14+
targetSdk 34
1515
versionCode 1
1616
versionName "1.0"
1717

0 commit comments

Comments
 (0)