Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for automatic URL path pattern discovery #774

Open
eyalkoren opened this issue Aug 4, 2019 · 2 comments
Open

Add ability for automatic URL path pattern discovery #774

eyalkoren opened this issue Aug 4, 2019 · 2 comments
Labels
enhancement Enhancement of an existing feature

Comments

@eyalkoren
Copy link
Contributor

When the use_path_as_transaction_name config option is used, this can lead to transaction name explosion if path parameters are used. For this purpose, we also have the url_groups config option, but it requires (possibly complex) user configuration.
By applying the algorithm presented in this POC, the agent can auto-discover URL path patterns and use them as transaction names.

The additional advantage of implementing this now is that we will have the option of testing this algorithm, which we may want to employ in the future to facilitate head-based sampling.

@nithril
Copy link

nithril commented Aug 11, 2019

Why not supporting the parametrized url that most frameworks have already implemented ?
eg. RequestMapping

@eyalkoren
Copy link
Contributor Author

Yeah, it would be a nice addition. We just recently added that for the @Path annotation.

This POC is something I wrote to demonstrate an algorithm that ALL Elastic APM agents can use in order to deal with a general problem that some agents have (in fact, other agents like Node more than Java) of computing the transaction name too late for some decision making, like whether to sample or not. With this, we can can do some decision making right when encountering the request.

I added this issue suggesting we can add it for transaction naming as well because it is the most generic approach (not restricted to specific frameworks) and because it can provide good feedback for us about how the algorithm behaves in real world applications.

@SylvainJuge SylvainJuge added enhancement Enhancement of an existing feature and removed [zube]: Backlog labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants