Implement net.bytebuddy.asm.Advice.ExceptionHandler to log exceptions in agent log

[felixbarny]

Currently, we are using net.bytebuddy.asm.Advice.ExceptionHandler.Default#PRINTING which means the exceptions may not be in the agent logs. We should create a custom net.bytebuddy.asm.Advice.ExceptionHandler which logs the exception with the agent logger.

If possible make that generic enough so that we can contribute that to Byte Buddy

[eyalkoren]

OR... contribute to ByteBuddy the ability to allow usage of plain Java dependency (as opposed to dependency on ByteBuddy interface) like java.util.function.Consumer<Throwable>, but preferably not Java 8 dependent

[felixbarny]

@raphw any recommendations on the approach? We’d like to contribute this to Byte Buddy if possible.

Can the advice templating be re-used for this? Something like

@OnAdviceException
private static void onException(@Thrown Throwable t) {
   // handle t
}

[raphw]

Not a bad idea, actually. One could write the exception to a free offset and make it available like that. This way, all the other annotations that work in (at)Enter advice would also work.

I have not looked into how difficult this would be to implement but it would certainly be possible.