Add unprivileged upgrade testing for Windows.

Author: blakerouse

testing/integration/upgrade_fleet_test.go

@@ -222,7 +222,12 @@ func testUpgradeFleetManagedElasticAgent(
 			t.Skipf("Ending version %s is less than 8.13 and doesn't support --unprivileged", endParsedVersion.String())
 		}
 		if runtime.GOOS != define.Linux {
-			t.Skip("Unprivileged mode is currently only supported on Linux")
+			if startParsedVersion.Less(*upgradetest.Version_8_14_0) {
+				t.Skipf("Starting version %s is less than 8.14 and doesn't support --unprivileged on Windows", startParsedVersion.String())
+			}
+			if endParsedVersion.Less(*upgradetest.Version_8_14_0) {
+				t.Skipf("Ending version %s is less than 8.14 and doesn't support --unprivileged on Windows", endParsedVersion.String())
+			}
 		}
 	}
 

testing/integration/upgrade_standalone_same_commit_test.go

@@ -52,15 +52,14 @@ func TestStandaloneUpgradeSameCommit(t *testing.T) {
 		t.Skipf("Minimum version for running this test is %q, current version: %q", *upgradetest.Version_8_13_0_SNAPSHOT, currentVersion)
 	}
 
-	unprivilegedAvailable := true
-	if runtime.GOOS != define.Linux {
-		// only available on Linux at the moment
-		unprivilegedAvailable = false
-	}
+	unprivilegedAvailable := false
 	// This is probably redundant: see the skip statement above
-	if unprivilegedAvailable && currentVersion.Less(*upgradetest.Version_8_13_0) {
-		// only available if both versions are 8.13+
-		unprivilegedAvailable = false
+	if runtime.GOOS == define.Linux && !currentVersion.Less(*upgradetest.Version_8_13_0) {
+		// only available if version is 8.13+ on Linux
+		unprivilegedAvailable = true
+	} else if !currentVersion.Less(*upgradetest.Version_8_14_0) {
+		// 8.14+ its always available
+		unprivilegedAvailable = true
 	}
 
 	unPrivilegedString := "unprivileged"

testing/integration/upgrade_standalone_test.go

@@ -36,14 +36,13 @@ func TestStandaloneUpgrade(t *testing.T) {
 	require.NoError(t, err)
 
 	for _, startVersion := range versionList {
-		unprivilegedAvailable := true
-		if runtime.GOOS != define.Linux {
-			// only available on Linux at the moment
-			unprivilegedAvailable = false
-		}
-		if unprivilegedAvailable && (startVersion.Less(*upgradetest.Version_8_13_0) || endVersion.Less(*upgradetest.Version_8_13_0)) {
-			// only available if both versions are 8.13+
-			unprivilegedAvailable = false
+		unprivilegedAvailable := false
+		if runtime.GOOS == define.Linux && !startVersion.Less(*upgradetest.Version_8_13_0) && !endVersion.Less(*upgradetest.Version_8_13_0) {
+			// unprivileged available if both versions are 8.13+ on Linux
+			unprivilegedAvailable = true
+		} else if !startVersion.Less(*upgradetest.Version_8_14_0) && !endVersion.Less(*upgradetest.Version_8_14_0) {
+			// always available if both versions are 8.14+
+			unprivilegedAvailable = true
 		}
 		t.Run(fmt.Sprintf("Upgrade %s to %s (privileged)", startVersion, define.Version()), func(t *testing.T) {
 			testStandaloneUpgrade(t, startVersion, define.Version(), false)

testing/upgradetest/upgrader.go

@@ -210,7 +210,12 @@ func PerformUpgrade(
 	// in the case that its explicitly set then we ensure the version supports it
 	if upgradeOpts.unprivileged == nil {
 		if !startVersion.Less(*Version_8_13_0) && !endVersion.Less(*Version_8_13_0) && runtime.GOOS == define.Linux {
-			// both version support --unprivileged
+			// both version support --unprivileged on Linux
+			unprivileged := true
+			upgradeOpts.unprivileged = &unprivileged
+			logger.Logf("installation of Elastic Agent will use --unprivileged as both start and end version support --unprivileged mode on Linux")
+		} else if !startVersion.Less(*Version_8_14_0) && !endVersion.Less(*Version_8_14_0) {
+			// both version support --unprivileged on all platforms
 			unprivileged := true
 			upgradeOpts.unprivileged = &unprivileged
 			logger.Logf("installation of Elastic Agent will use --unprivileged as both start and end version support --unprivileged mode")

testing/upgradetest/versions.go

@@ -35,8 +35,10 @@ var (
 	Version_8_11_0_SNAPSHOT = version.NewParsedSemVer(8, 11, 0, "SNAPSHOT", "")
 	// Version_8_13_0_SNAPSHOT is the minimum version for testing upgrading agent with the same hash
 	Version_8_13_0_SNAPSHOT = version.NewParsedSemVer(8, 13, 0, "SNAPSHOT", "")
-	// Version_8_13_0 is the minimum version for proper unprivileged execution
+	// Version_8_13_0 is the minimum version for proper unprivileged execution on Linux
 	Version_8_13_0 = version.NewParsedSemVer(8, 13, 0, "", "")
+	// Version_8_14_0 is the minimum version for proper unprivileged execution on all platforms
+	Version_8_14_0 = version.NewParsedSemVer(8, 14, 0, "", "")
 
 	// ErrNoSnapshot is returned when a requested snapshot is not on the version list.
 	ErrNoSnapshot = errors.New("failed to find a snapshot on the version list")