Use the remove function from install

Remove the custom removeAll function in favour of the
install.RemovePath that already exists.

Author: belimawr

pkg/testing/fixture.go

@@ -26,6 +26,7 @@ import (
 
 	"github.com/elastic/elastic-agent/internal/pkg/agent/application/paths"
 	"github.com/elastic/elastic-agent/internal/pkg/agent/application/upgrade/details"
+	"github.com/elastic/elastic-agent/internal/pkg/agent/install"
 	"github.com/elastic/elastic-agent/pkg/component"
 	"github.com/elastic/elastic-agent/pkg/control"
 	"github.com/elastic/elastic-agent/pkg/control/v2/client"
@@ -1209,7 +1210,7 @@ func createTempDir(t *testing.T) string {
 
 	cleanup := func() {
 		if !t.Failed() {
-			if err := removeAll(tempDir); err != nil {
+			if err := install.RemovePath(tempDir); err != nil {
 				t.Errorf("could not remove temp dir '%s': %s", tempDir, err)
 			}
 		} else {
@@ -1221,37 +1222,6 @@ func createTempDir(t *testing.T) string {
 	return tempDir
 }
 
-// removeAll tries to remove path, if it fails and the error
-// is retry able (only on Windows), it will keep retrying with an exponential
-// backoff up to 3 seconds.
-func removeAll(path string) error {
-	maxBackoffTime := 3 * time.Second
-	myyBackoff := backoff.NewExponentialBackOff(
-		backoff.WithMaxElapsedTime(maxBackoffTime),
-		backoff.WithInitialInterval(time.Millisecond))
-
-	myyBackoff.Reset()
-	for {
-		err := os.RemoveAll(path)
-		if err == nil {
-			break
-		}
-
-		if !isWindowsRetryable(err) {
-			return fmt.Errorf("could not remove temp dir '%s': %s", path, err)
-		}
-
-		interval := myyBackoff.NextBackOff()
-		if interval == backoff.Stop {
-			return fmt.Errorf("could not remove '%s' after waiting for %s: %w", path, maxBackoffTime, err)
-		}
-
-		time.Sleep(interval)
-	}
-
-	return nil
-}
-
 type AgentStatusOutput struct {
 	Info struct {
 		ID           string `json:"id"`