add asserts on metadata.Elastic.Agent

Author: pchila

internal/pkg/agent/application/gateway/fleet/fleet_gateway.go

@@ -329,14 +329,9 @@ func (f *FleetGateway) execute(ctx context.Context) (*fleetapi.CheckinResponse,
 	// convert components into checkin components structure
 	components := f.convertToCheckinComponents(state.Components)
 
-	if ecsMeta.Elastic == nil || ecsMeta.Elastic.Agent == nil {
-		// escMeta struct is incomplete: log a warning
-		f.log.Warnw("Agent ECSMetadata struct is missing/incomplete", "elastic_ecs_metadata", ecsMeta.Elastic)
-	} else {
-		f.log.Debugf("correcting agent loglevel from %s to %s using coordinator state", ecsMeta.Elastic.Agent.LogLevel, state.LogLevel.String())
-		// Fix loglevel with the current log level used by coordinator
-		ecsMeta.Elastic.Agent.LogLevel = state.LogLevel.String()
-	}
+	f.log.Debugf("correcting agent loglevel from %s to %s using coordinator state", ecsMeta.Elastic.Agent.LogLevel, state.LogLevel.String())
+	// Fix loglevel with the current log level used by coordinator
+	ecsMeta.Elastic.Agent.LogLevel = state.LogLevel.String()
 
 	// checkin
 	cmd := fleetapi.NewCheckinCmd(f.agentInfo, f.client)

internal/pkg/agent/application/info/agent_metadata_test.go

@@ -29,6 +29,10 @@ func TestECSMetadata(t *testing.T) {
 	metadata, err := agentInfo.ECSMetadata(l)
 	require.NoError(t, err)
 
+	if assert.NotNil(t, metadata.Elastic, "metadata.Elastic must not be nil") {
+		assert.NotNil(t, metadata.Elastic.Agent, "metadata.Elastic.Agent must not be nil")
+	}
+
 	sysInfo, err := sysinfo.Host()
 	require.NoError(t, err)