Skip to content

Commit 49a9dfc

Browse files
committed
fixed bug
1 parent bacda1f commit 49a9dfc

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

magefile.go

+22-22
Original file line numberDiff line numberDiff line change
@@ -1273,30 +1273,34 @@ func fileHelperNoManifest(versionedFlatPath string, versionedDropPath string, pa
12731273
return checksums
12741274
}
12751275

1276-
func getComponentVersion(componentName string, requiredPackage string, componentProject tools.Project, agentComponents map[string]string) string {
1276+
func getComponentVersion(componentName string, requiredPackage string, componentProject tools.Project, externalBinaries map[string]string) string {
12771277
var componentVersion string
12781278
for pkgName, _ := range componentProject.Packages {
12791279
log.Printf(">>>>>>>>>>> XXX getComponentVersion Package: %s <<<<", pkgName)
1280-
pkgPrefix := agentComponents[componentName]
1281-
firstSplit := strings.Split(pkgName, pkgPrefix+"-")
1282-
if len(firstSplit) < 2 {
1283-
continue
1284-
}
1285-
secondHalf := firstSplit[1]
1286-
if len(secondHalf) < 2 {
1287-
continue
1288-
}
1289-
if strings.Contains(secondHalf, requiredPackage) {
1290-
log.Printf(">>>>>>>>>>> XXX Second Half: %s <<<<", secondHalf)
1291-
if strings.Contains(secondHalf, "docker-image") {
1280+
for binaryPrefix, binaryComponent := range externalBinaries {
1281+
if componentName != binaryComponent {
12921282
continue
12931283
}
1294-
if strings.Contains(secondHalf, "oss-") {
1284+
firstSplit := strings.Split(pkgName, binaryPrefix+"-")
1285+
if len(firstSplit) < 2 {
12951286
continue
12961287
}
1297-
componentVersion = strings.Split(secondHalf, "-"+requiredPackage)[0]
1298-
log.Printf(">>>>>>>>>>> XXX Got Version: %s <<<<", componentVersion)
1299-
break
1288+
secondHalf := firstSplit[1]
1289+
if len(secondHalf) < 2 {
1290+
continue
1291+
}
1292+
if strings.Contains(secondHalf, requiredPackage) {
1293+
log.Printf(">>>>>>>>>>> XXX Second Half: %s <<<<", secondHalf)
1294+
if strings.Contains(secondHalf, "docker-image") {
1295+
continue
1296+
}
1297+
if strings.Contains(secondHalf, "oss-") {
1298+
continue
1299+
}
1300+
componentVersion = strings.Split(secondHalf, "-"+requiredPackage)[0]
1301+
log.Printf(">>>>>>>>>>> XXX Got Version: %s <<<<", componentVersion)
1302+
break
1303+
}
13001304
}
13011305
}
13021306

@@ -1347,7 +1351,7 @@ func fileHelperWithManifest(requiredPackage string, versionedFlatPath string, ve
13471351
}
13481352
log.Printf(">>>>>>> XXX Pkg [%s] matches requiredPackage [%s]", pkgName, requiredPackage)
13491353

1350-
componentVersion := getComponentVersion(componentName, requiredPackage, projects[componentName], agentComponents)
1354+
componentVersion := getComponentVersion(componentName, requiredPackage, projects[componentName], externalBinaries)
13511355
log.Printf(">>>>>>> XXX [%s] [%s] version is [%s]", componentName, requiredPackage, componentVersion)
13521356

13531357
fullPath := filepath.Join(versionedFlatPath, pkgName)
@@ -1479,10 +1483,6 @@ func flattenDependencies(requiredPackages []string, packageVersion, archivePath,
14791483
panic(err)
14801484
}
14811485
}
1482-
1483-
log.Printf(">>>> XXX Sleeping....")
1484-
time.Sleep(60 * time.Second)
1485-
log.Printf(">>>> XXX Done Sleeping....")
14861486
}
14871487

14881488
// simple struct to deserialize branch information.

0 commit comments

Comments
 (0)