Skip to content

Commit 4da14b8

Browse files
authored
Add Ubuntu 24.04 to integration testing. (#4898)
* Add Ubuntu 24.04 to integration testing. * Fix unit test. * Add -amd64 to end.
1 parent 2e09c33 commit 4da14b8

File tree

4 files changed

+50
-1
lines changed

4 files changed

+50
-1
lines changed

pkg/testing/multipass/provisioner.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func (p *provisioner) Supported(os define.OS) bool {
5454
if os.Distro != Ubuntu {
5555
return false
5656
}
57-
if os.Version != "20.04" && os.Version != "22.04" {
57+
if os.Version != "20.04" && os.Version != "22.04" && os.Version != "24.04" {
5858
return false
5959
}
6060
// multipass only supports the same architecture of the host

pkg/testing/ogc/supported.go

+26
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,19 @@ const (
2020
// one in this list will be picked. So it's best to place the one that we want the
2121
// most testing at the top.
2222
var ogcSupported = []LayoutOS{
23+
{
24+
OS: define.OS{
25+
Type: define.Linux,
26+
Arch: define.AMD64,
27+
Distro: runner.Ubuntu,
28+
Version: "24.04",
29+
},
30+
Provider: Google,
31+
InstanceSize: "e2-standard-2", // 2 amd64 cpus, 8 GB RAM
32+
RunsOn: "ubuntu-2404-lts-amd64",
33+
Username: "ubuntu",
34+
RemotePath: "/home/ubuntu/agent",
35+
},
2336
{
2437
OS: define.OS{
2538
Type: define.Linux,
@@ -54,6 +67,19 @@ var ogcSupported = []LayoutOS{
5467
// Type: define.Linux,
5568
// Arch: define.ARM64,
5669
// Distro: runner.Ubuntu,
70+
// Version: "24.04",
71+
// },
72+
// Provider: Google,
73+
// InstanceSize: "t2a-standard-4", // 4 arm64 cpus, 16 GB RAM
74+
// RunsOn: "ubuntu-2404-lts-arm64",
75+
// Username: "ubuntu",
76+
// RemotePath: "/home/ubuntu/agent",
77+
// },
78+
// {
79+
// OS: define.OS{
80+
// Type: define.Linux,
81+
// Arch: define.ARM64,
82+
// Distro: runner.Ubuntu,
5783
// Version: "22.04",
5884
// },
5985
// Provider: Google,

pkg/testing/runner/supported.go

+22
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,16 @@ type SupportedOS struct {
3131
}
3232

3333
var (
34+
// UbuntuAMD64_2404 - Ubuntu (amd64) 24.04
35+
UbuntuAMD64_2404 = SupportedOS{
36+
OS: define.OS{
37+
Type: define.Linux,
38+
Arch: define.AMD64,
39+
Distro: Ubuntu,
40+
Version: "24.04",
41+
},
42+
Runner: DebianRunner{},
43+
}
3444
// UbuntuAMD64_2204 - Ubuntu (amd64) 22.04
3545
UbuntuAMD64_2204 = SupportedOS{
3646
OS: define.OS{
@@ -51,6 +61,16 @@ var (
5161
},
5262
Runner: DebianRunner{},
5363
}
64+
// UbuntuARM64_2404 - Ubuntu (arm64) 24.04
65+
UbuntuARM64_2404 = SupportedOS{
66+
OS: define.OS{
67+
Type: define.Linux,
68+
Arch: define.ARM64,
69+
Distro: Ubuntu,
70+
Version: "24.04",
71+
},
72+
Runner: DebianRunner{},
73+
}
5474
// UbuntuARM64_2204 - Ubuntu (arm64) 22.04
5575
UbuntuARM64_2204 = SupportedOS{
5676
OS: define.OS{
@@ -146,8 +166,10 @@ var (
146166
// one in this list will be picked. So it's best to place the one that we want the
147167
// most testing at the top.
148168
var supported = []SupportedOS{
169+
UbuntuAMD64_2404,
149170
UbuntuAMD64_2204,
150171
UbuntuAMD64_2004,
172+
UbuntuARM64_2404,
151173
UbuntuARM64_2204,
152174
UbuntuARM64_2004,
153175
RhelAMD64_8,

pkg/testing/runner/supported_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ func TestGetSupported(t *testing.T) {
3737
Distro: Ubuntu,
3838
},
3939
Results: []SupportedOS{
40+
UbuntuAMD64_2404,
4041
UbuntuAMD64_2204,
4142
UbuntuAMD64_2004,
4243
},

0 commit comments

Comments
 (0)