test: check condition early for TestHTTPReloadEnableBehavior (#5418)

we're relying on assert.Eventually with a wait time of 3s
we call it twice per test in 4 total tests
minimum test time should be 3*2*4=24s

Update assertion to check the condition before calling
eventually

Test time went from 24.101s to 0.264s

Author: kruskall

internal/pkg/agent/application/monitoring/server_test.go

@@ -146,7 +146,7 @@ func waitOnReturnCode(t *testing.T, expectedReturnCode int, formValue string, re
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
 	defer cancel()
 	client := &http.Client{}
-	require.Eventually(t, func() bool {
+	fastEventually(t, func() bool {
 		path := fmt.Sprintf("http://%s/liveness%s", rel.Addr().String(), formValue)
 		t.Logf("checking %s", path)
 		req, err := http.NewRequestWithContext(ctx, "GET", path, nil)
@@ -163,6 +163,14 @@ func waitOnReturnCode(t *testing.T, expectedReturnCode int, formValue string, re
 	}, time.Second*30, time.Second*3)
 }
 
+func fastEventually(t *testing.T, condition func() bool, waitFor time.Duration, tick time.Duration) {
+	if condition() {
+		return
+	}
+
+	require.Eventually(t, condition, waitFor, tick)
+}
+
 func TestIsHTTPUrl(t *testing.T) {
 
 	tests := []struct {