Diagnostics: rename components-actual.yaml to components-observed.yaml

[ycombinator]

Follow up to #2139.

Now that #2139 has been implemented, elastic-agent diagnostics will create an archive containing the following files (only those relevant to this discussion are shown below):

• components-expected.yaml
• components-actual.yaml

From my understanding after chatting with @pchila:

• components-expected.yaml represents the expected state of the components, as is sent by the Agent to it's components via the CheckinExpected message.
• components-actual.yaml represents the observed state of the components, as is sent by the components to the Agent via the CheckinObserved message.

Assuming my understanding above is correct, then I propose renaming components-actual.yaml to components-observed.yaml so the filenames are consistent with the names of their corresponding protocol messages. This will avoid unnecessary confusion about what exactly compnents-actual.yaml might represent and whether it's the same or slightly different that the observed state of the components, as is sent by the components to the Agent via the CheckinObserved message.

[cmacknz]

I suggested the original name and this change is fine with me. We haven't released this yet so there's no reason to avoid changing it.

[pierrehilbert]

Now it has been released, what is your opinion @cmacknz ?

[cmacknz]

We can still change it, subject to updating documentation.

I don't personally look at these two files often, I'm not sure how much value there is doing the rename now. I'll defer to @ycombinator to close or prioritize as needed.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[ycombinator]

I think it's worth changing the name (and associated documentation) but the current naming hasn't been problematic so I will deprioritize this issue.