[Flaky Test]: TestCloseChannel/EqualJitterBackoff – Should be false

[rdner]

Failing test case

TestCloseChannel/EqualJitterBackoff

Error message

Should be false

Build

https://buildkite.com/elastic/elastic-agent/builds/7764#018e3888-360a-47b4-b8f1-04255d95d697

OS

Mac

Stacktrace and notes

=== FAIL: internal/pkg/core/backoff TestCloseChannel/EqualJitterBackoff (0.01s)
    backoff_test.go:35:
        	Error Trace:	/Users/admin/builds/bk-agent-prod-orka-1710345447011028072/elastic/elastic-agent/internal/pkg/core/backoff/backoff_test.go:35
        	Error:      	Should be false
        	Test:       	TestCloseChannel/EqualJitterBackoff
=== FAIL: internal/pkg/core/backoff TestCloseChannel (0.01s)

[elasticmachine]

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

[cmacknz]

The initial wait is a random integer in the range (0, 2E9] where the units are ns as those are the underlying units of time.Duration. So the initial wait is plausibly 1 ns some of the time.

Edit: I read the code too quickly, we are always guaranteed to wait for at least init:

elastic-agent/internal/pkg/core/backoff/equal_jitter.go

Lines 27 to 29 in 6135d60

	func NewEqualJitterBackoff(done <-chan struct{}, init, max time.Duration) Backoff {
	return &EqualJitterBackoff{
	duration: init * 2, // Allow to sleep at least the init period on the first wait.

elastic-agent/internal/pkg/core/backoff/equal_jitter.go

Lines 44 to 45 in 6135d60

	// Make sure we have always some minimal back off and jitter.
	temp := b.duration / 2

Increasing init should hopefully fix this.