-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using the artifact API in artifact downloads #4458
Comments
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
We should be able to just use https://snapshots.elastic.co/ instead. |
I talked to the team who owns the snapshot API. TLDR; It's possible to get a manifest for a certain version snapshot, e.g. Which covers our exact use-case described in this issue. Also, supported use-cases are:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Describe the enhancement:
This is a follow up to #4417
We must stop using the artifact API in our artifact downloader here
elastic-agent/internal/pkg/agent/application/upgrade/artifact/download/snapshot/downloader.go
Line 127 in 8fc1874
And the artifact fetcher in tests here
elastic-agent/pkg/testing/fetcher_artifact.go
Line 178 in 8fc1874
Describe a specific use case for the enhancement or feature:
The artifact API is unstable and we cannot rely on it: recent failure example is https://buildkite.com/elastic/elastic-agent/builds/7900#018e617f-f132-46da-b9cd-625a6741682e
More examples can be found here #4268
Sometimes it starts returning 502 for several minutes and it fails our tests and might fail in production when upgrading to a snapshot (rare use-case).
What is the definition of done?
The artifact downloader in the agent and the artifact fetcher in tests are using an alternative source of versions not involving the artifact API.
The text was updated successfully, but these errors were encountered: