Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel mode] Replace memorylimitprocessor with memorylimitextension #4665

Closed
4 tasks
ycombinator opened this issue May 3, 2024 · 1 comment · Fixed by #4689
Closed
4 tasks

[OTel mode] Replace memorylimitprocessor with memorylimitextension #4665

ycombinator opened this issue May 3, 2024 · 1 comment · Fixed by #4689
Assignees
@michalpristas
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ycombinator
Copy link
Contributor

ycombinator commented May 3, 2024 •
edited by michalpristas
Loading

Describe the enhancement:

As recommended by @michalpristas in #4623 (comment):

maybe not in this PR but we will need to replace memorylimiterprocessor with memorylimiterextension. difference is behavior is that processors drops the events and extensions acts as a pushback mechanism stopping/pausing processing on receiver side

What is the definition of done?

  • ./elastic-agent otel validate -c otel.yml fails if memorylimiterprocessor is used in the otel.yml collector configuration.
  • ./elastic-agent otel validate -c otel.yml succeeds if memorylimiterextension is used in the otel.yml collector configuration.
  • documentation updated
  • example configuration
@ycombinator ycombinator added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels May 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator mentioned this issue May 3, 2024
Closed
7 tasks
@michalpristas michalpristas self-assigned this May 6, 2024
@michalpristas michalpristas mentioned this issue May 7, 2024
Merged
@mergify mergify bot mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalpristas michalpristas

Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing memory limiter processor with extension michalpristas/elastic-agent
3 participants
@ycombinator @michalpristas @elasticmachine