Use oapi-codegen to generate server router (#2322)

Use the oapi-codegen tool to generate a chi-server router to make sure
that the openapi spec is the source of truth for fleet-server's 
interactions. Change how the listeners/routers are created and started,
propagate X-Request-Id values in responses, attach and use request
specific loggers with additional context for listeners.

Changed some of the api spec to allow strings instead of UUIDs
Uses a forked version of the oapi-codegen module as some of its
dependencies needed to be updated.
Uses go-chi/chi and standard net/http patterns instead of httprouter

Author: michel-laterman

.github/workflows/golangci-lint.yml

@@ -38,7 +38,7 @@ jobs:
         uses: golangci/golangci-lint-action@v2
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.47.2
+          version: v1.51.1
 
           # Give the job more time to execute.
           # Regarding `--whole-files`, the linter is supposed to support linting of changed a patch only but,

.golangci.yml

@@ -3,6 +3,7 @@ run:
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 1m
   build-tags: integration
+  go: "1.18.10"
 
 issues:
   # Maximum count of issues with the same text.
@@ -28,13 +29,12 @@ output:
 linters:
   disable-all: true
   enable:
-    - deadcode # finds unused code
     - errcheck # checking for unchecked errors in go programs
     - errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
     - goconst # finds repeated strings that could be replaced by a constant
     - dupl # tool for code clone detection
     - forbidigo # forbids identifiers	matched by reg exps
-    #- gomoddirectives # manage the use of 'replace', 'retract', and 'excludes' directives in go.mod.
+    - gomoddirectives # manage the use of 'replace', 'retract', and 'excludes' directives in go.mod.
     - gosimple # linter for Go source code that specializes in simplifying a code
     - misspell # finds commonly misspelled English words in comments
     - nakedret # finds naked returns in functions greater than a specified function length
@@ -48,9 +48,7 @@ linters:
     - gomodguard
     - govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
     - ineffassign # detects when assignments to existing variables are not used
-    - structcheck # finds unused struct fields
     - typecheck # Like the front-end of a Go compiler, parses and type-checks Go code
-    - varcheck # Finds unused global variables and constants
     - asciicheck # simple linter to check that your code does not contain non-ASCII identifiers
     - bodyclose # checks whether HTTP response body is closed successfully
     - durationcheck # check for two durations multiplied together
@@ -61,8 +59,12 @@ linters:
     - nilerr # finds the code that returns nil even if it checks that the error is not nil.
     - noctx # noctx finds sending http request without context.Context
     - unconvert # Remove unnecessary type conversions
-    - wastedassign # wastedassign finds wasted assignment statements.
+    #- wastedassign # wastedassign finds wasted assignment statements. # NOTE disabled due to lack of generics support
     #- godox # tool for detection of FIXME, TODO and other comment keywords
+    - asasalint
+    - bidichk
+    - gocheckcompilerdirectives
+    - tenv
 
 
 # all available settings of specific linters
@@ -101,28 +103,7 @@ linters-settings:
     # Allow local `replace` directives. Default is false.
     replace-local: false
     replace-allow-list:
-      - github.com/Shopify/sarama
-      - github.com/dop251/goja
-      - github.com/fsnotify/fsevents
-
-  gomodguard:
-    blocked:
-      # List of blocked modules.
-      modules:
-        - github.com/elastic/beats/v7:
-            reason: "There must be no Beats dependency, use elastic-agent-libs instead."
-
-  gosimple:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.18.10"
-
-  misspell:
-    # Correct spellings using locale preferences for US or UK.
-    # Default is to use a neutral variety of English.
-    # Setting locale to US will correct the British spelling of 'colour' to 'color'.
-    # locale: US
-    # ignore-words:
-    #   - IdP
+      - github.com/deepmap/oapi-codegen
 
   nakedret:
     # make an issue if func has more lines of code than this setting and it has naked returns; default is 30
@@ -147,23 +128,22 @@ linters-settings:
     # Enable to require nolint directives to mention the specific linter being suppressed. Default is false.
     require-specific: true
 
-  staticcheck:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.18.10"
-
   stylecheck:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.18.10"
     initialisms: ["ACL", "API", "ASCII", "CPU", "CSS", "DNS", "EOF", "GUID", "HTML", "HTTP", "HTTPS", "ID", "IP", "JSON", "QPS", "RAM", "RPC", "SLA", "SMTP", "SQL", "SSH", "TCP", "TLS", "TTL", "UDP", "UI", "GID", "UID", "UUID", "URI", "URL", "UTF8", "VM", "XML", "XMPP", "XSRF", "XSS", "ECS"]
 
-
   unparam:
     # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
     # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
     # if it's called for subdir of a project it can't find external interfaces. All text editor integrations
     # with golangci-lint call it on a directory with the changed file.
     check-exported: false
 
-  unused:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.18.10"
+  gomodguard:
+    blocked:
+      # List of blocked modules.
+      modules:
+        - github.com/elastic/beats/v7:
+            reason: "There must be no Beats dependency, use elastic-agent-libs instead."
+        - github.com/elastic/beats/elastic-agent:
+            reason: "There must be no elastic-agent dependency, use elastic-agent-libs instead."
+

Makefile

@@ -66,6 +66,8 @@ clean: ## - Clean up build artifacts
 generate: ## - Generate schema models
 	@printf "${CMD_COLOR_ON} Installing module for go generate\n${CMD_COLOR_OFF}"
 	env GOBIN=${GOBIN} go install github.com/elastic/go-json-schema-generate/cmd/schema-generate@ec19b88f6b5ef7825a928df8274a99337b855d1f
+	@printf "${CMD_COLOR_ON} Installing module for oapi-codegen\n${CMD_COLOR_OFF}"
+	env GOBIN=${GOBIN} go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@latest
 	@printf "${CMD_COLOR_ON} Running go generate\n${CMD_COLOR_OFF}"
 	env PATH="${GOBIN}:${PATH}" go generate ./...
 
@@ -88,7 +90,7 @@ check-headers:  ## - Check copyright headers
 
 .PHONY: check-go
 check-go: ## - Run golangci-lint
-	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/d58dbde584c801091e74a00940e11ff18c6c68bd/install.sh | sh -s v1.47.2
+	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/d58dbde584c801091e74a00940e11ff18c6c68bd/install.sh | sh -s v1.51.1
 	@./bin/golangci-lint run -v
 
 .PHONY: notice