diff --git a/internal/pkg/bulk/setup_test.go b/internal/pkg/bulk/setup_test.go index 1919fdbf7..6791a1e5f 100644 --- a/internal/pkg/bulk/setup_test.go +++ b/internal/pkg/bulk/setup_test.go @@ -15,6 +15,7 @@ import ( "time" "github.com/Pallinder/go-randomdata" + "github.com/elastic/go-elasticsearch/v8" "github.com/elastic/go-ucfg/yaml" "github.com/rs/xid" @@ -133,7 +134,11 @@ func SetupBulk(ctx context.Context, t testing.TB, opts ...BulkOpt) Bulk { // Set up the client with username and password since this test is generic for any index and uses it's own index/mapping e := getEnvironment() - cli, err := es.NewClient(ctx, &defaultCfg, false, es.WithUsrPwd(e.Username, e.Password)) + cli, err := es.NewClient(ctx, &defaultCfg, false, func(config *elasticsearch.Config) { + config.ServiceToken = "" // reset service token + config.Username = e.Username + config.Password = e.Password + }) if err != nil { t.Fatal(err) } diff --git a/internal/pkg/es/client.go b/internal/pkg/es/client.go index 96b53cf62..e81cdd6d4 100644 --- a/internal/pkg/es/client.go +++ b/internal/pkg/es/client.go @@ -61,15 +61,6 @@ func WithUserAgent(name string, bi build.Info) ConfigOption { } } -// WithUsrPwd is intended to be used by integration tests ONLY! -func WithUsrPwd(usr, pwd string) ConfigOption { - return func(config *elasticsearch.Config) { - config.ServiceToken = "" // reset service token - config.Username = usr - config.Password = pwd - } -} - func InstrumentRoundTripper() ConfigOption { return func(config *elasticsearch.Config) { config.Transport = apmelasticsearch.WrapRoundTripper(