Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace/remove references to defunct freenode instance #16873

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Jan 7, 2025

Release notes

[rn:skip]

What does this PR do?

Remove references to defunct freenode IRC and replace with preferred discussion forum.

Why is it important/What is the impact to the user?

Point folks at the preferred public discussion forum.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Closes #16851

The preferred channel for communication about LS is the elastic discussion
forum, this commit updates the source code and readme files to reflect that.
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc
Copy link
Member Author

Thanks for the review @robbavey Does this just need to go into the main and 8.x branches? Or do you want it in the other active streams as well?

@robbavey
Copy link
Member

Let's just put it in main and 8.x for now

@donoghuc donoghuc merged commit 356ecb3 into elastic:main Jan 10, 2025
6 checks passed
@donoghuc
Copy link
Member Author

@logstashmachine backport 8.x

@donoghuc
Copy link
Member Author

🤦 of course this wont cleanly backport #16873 (comment) due to #16863 will work up a manual one.

donoghuc added a commit to donoghuc/logstash that referenced this pull request Jan 10, 2025
The preferred channel for communication about LS is the elastic discussion
forum, this commit updates the source code and readme files to reflect that.
@donoghuc
Copy link
Member Author

Backport PR #16897

donoghuc added a commit to donoghuc/logstash that referenced this pull request Jan 11, 2025
The preferred channel for communication about LS is the elastic discussion
forum, this commit updates the source code and readme files to reflect that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace references to freenode irc
3 participants