Check server URL

Author: mickel8

client.go

@@ -5,12 +5,14 @@ import (
 	"errors"
 	"io"
 	"net/http"
+	"net/url"
 
 	"github.com/pion/interceptor"
 	"github.com/pion/webrtc/v4"
 )
 
 var (
+	ErrInvalidURL         = errors.New("Invalid server URL")
 	ErrFailedToConnect    = errors.New("Failed to connect")
 	ErrNoLocationHeader   = errors.New("No location header in the response")
 	ErrFailedToDisconnect = errors.New("Failed to remove server resource")
@@ -24,11 +26,16 @@ type Client struct {
 	location string
 }
 
-func New(url string, pcConfig webrtc.Configuration) (*Client, error) {
+func New(urlString string, pcConfig webrtc.Configuration) (*Client, error) {
+	_, err := url.ParseRequestURI(urlString)
+	if err != nil {
+		return nil, ErrInvalidURL
+	}
+
 	interceptorRegistry := &interceptor.Registry{}
 	mediaEngine := &webrtc.MediaEngine{}
 
-	err := mediaEngine.RegisterDefaultCodecs()
+	err = mediaEngine.RegisterDefaultCodecs()
 	if err != nil {
 		return nil, err
 	}
@@ -47,7 +54,7 @@ func New(url string, pcConfig webrtc.Configuration) (*Client, error) {
 
 	client := &Client{
 		Pc:       pc,
-		url:      url,
+		url:      urlString,
 		pcConfig: pcConfig,
 	}
 

client_test.go

@@ -12,10 +12,15 @@ import (
 )
 
 func TestNew(t *testing.T) {
-	_, err := New("", webrtc.Configuration{})
+	_, err := New("http://example.com", webrtc.Configuration{})
 	if err != nil {
 		t.Fatalf("New returned an error %v", err)
 	}
+
+	_, err = New("", webrtc.Configuration{})
+	if err != ErrInvalidURL {
+		t.Fatalf("Expected %s, got: %v", ErrInvalidURL, err)
+	}
 }
 
 func TestConnect(t *testing.T) {