extract the text attribute if json parsing failed

Author: tcm390

packages/client-twitter/src/post.ts

@@ -10,6 +10,7 @@ import {
     type UUID,
     truncateToCompleteSentence,
     parseJSONObjectFromText,
+    extractAttributes,
 } from "@elizaos/core";
 import { elizaLogger } from "@elizaos/core";
 import type { ClientBase } from "./base.ts";
@@ -463,6 +464,14 @@ export class TwitterPostClient {
         }
     }
 
+    /**
+     * Cleans a JSON-like response string by removing unnecessary markers, line breaks, and extra whitespace.
+     * This is useful for handling improperly formatted JSON responses from external sources.
+     *
+     * @param response - The raw JSON-like string response to clean.
+     * @returns The cleaned string, ready for parsing or further processing.
+     */
+
     cleanJsonResponse(response: string): string {
         return response
             .replace(/```json\s*/g, "") // Remove ```json
@@ -548,6 +557,12 @@ export class TwitterPostClient {
                     .trim();
             }
 
+            if (!cleanedContent) {
+                cleanedContent = extractAttributes(newTweetContent, [
+                    "text",
+                ]).text;
+            }
+
             if (!cleanedContent) {
                 elizaLogger.error(
                     "Failed to extract valid content from response:",
@@ -672,11 +687,17 @@ export class TwitterPostClient {
                 response,
             );
         }
-        // If not JSON or no valid content found, clean the raw text
-        const truncateContent = truncateToCompleteSentence(
-            cleanedResponse,
-            this.client.twitterConfig.MAX_TWEET_LENGTH,
-        );
+
+        let truncateContent = extractAttributes(cleanedResponse, ["text"]).text;
+
+        if (!truncateContent) {
+            // If not JSON or no valid content found, clean the raw text
+            truncateContent = truncateToCompleteSentence(
+                cleanedResponse,
+                this.client.twitterConfig.MAX_TWEET_LENGTH,
+            );
+        }
+
         return truncateContent;
     }
 

packages/core/src/parsing.ts

@@ -173,6 +173,30 @@ export function parseJSONObjectFromText(
     }
 }
 
+/**
+ * Extracts specific attributes (e.g., user, text, action) from a JSON-like string using regex.
+ * @param response - The cleaned string response to extract attributes from.
+ * @param attributesToExtract - An array of attribute names to extract.
+ * @returns An object containing the extracted attributes.
+ */
+export function extractAttributes(
+    response: string,
+    attributesToExtract: string[],
+): { [key: string]: string | undefined } {
+    const attributes: { [key: string]: string | undefined } = {};
+
+    attributesToExtract.forEach((attribute) => {
+        const match = response.match(
+            new RegExp(`"${attribute}"\\s*:\\s*"([^"]*)"`, "i"),
+        );
+        if (match) {
+            attributes[attribute] = match[1];
+        }
+    });
+
+    return attributes;
+}
+
 export const postActionResponseFooter = `Choose any combination of [LIKE], [RETWEET], [QUOTE], and [REPLY] that are appropriate. Each action must be on its own line. Your response must only include the chosen actions.`;
 
 export const parseActionResponseFromText = (