Skip to content

Commit 1621048

Browse files
authored
Merge pull request #1120 from Sifchain/realitySpiral/lockFileFix
fix: Refactor to prevent unnecessary lockfile changes
2 parents 3085635 + 551025e commit 1621048

File tree

7 files changed

+20
-8
lines changed

7 files changed

+20
-8
lines changed

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
cache: "pnpm"
2121

2222
- name: Install dependencies
23-
run: pnpm install --frozen-lockfile
23+
run: pnpm install
2424

2525
- name: Run Prettier
2626
run: pnpm run prettier --check .

.github/workflows/integrationTests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
cache: "pnpm"
3939

4040
- name: Install dependencies
41-
run: pnpm install -r --frozen-lockfile
41+
run: pnpm install -r
4242

4343
- name: Build packages
4444
run: pnpm build

.gitpod.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@ tasks:
44
init: |
55
nvm install v23.3.0
66
git checkout $(git describe --tags --abbrev=0)
7-
command: pnpm install && pnpm run build
8-
7+
command: pnpm install && pnpm run build

.npmrc

+1
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
node-linker=hoisted
2+
frozen-lockfile=true

docs/docs/quickstart.md

+14-2
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,24 @@ Before getting started with Eliza, ensure you have:
3939
git checkout $(git describe --tags --abbrev=0)
4040
```
4141

42-
Install dependencies
42+
Install dependencies (on initial run)
4343

4444
```bash
45-
pnpm install
45+
pnpm install --no-frozen-lockfile
4646
```
4747

48+
# Quickstart Guide Update
49+
50+
**Important Note on pnpm Lockfile Management**
51+
52+
By default, the `pnpm` lockfile will not be updated during installations based off of .npmrc frozen-lockfile=true. To update the lockfile, you need to run the command:
53+
54+
```bash
55+
pnpm install --no-frozen-lockfile
56+
```
57+
58+
Please only use this command when you initially instantiating the repo or are bumping the version of a package or adding a new package to your package.json. This practice helps maintain consistency in your project's dependencies and prevents unintended changes to the lockfile.
59+
4860
Build the local libraries
4961

5062
```bash

scripts/smokeTests.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ cd "$PROJECT_DIR"
3636

3737
cp .env.example .env
3838

39-
pnpm install -r --frozen-lockfile
39+
pnpm install -r
4040

4141
pnpm build
4242

scripts/start.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ fi
2121

2222
# Install dependencies
2323
echo -e "\033[1mInstalling dependencies...\033[0m"
24-
if ! pnpm i; then
24+
if ! pnpm i ; then
2525
echo -e "\033[1;31mFailed to install dependencies\033[0m"
2626
exit 1
2727
fi

0 commit comments

Comments
 (0)