test more generateSHouldRespond

Author: wtfsayo

packages/client-discord/src/index.ts

@@ -15,7 +15,7 @@ import {
     Partials,
     type User,
 } from "discord.js";
-import { EventEmitter } from "events";
+import { EventEmitter } from "node:events";
 import chat_with_attachments from "./actions/chat_with_attachments.ts";
 import download_media from "./actions/download_media.ts";
 import joinvoice from "./actions/joinvoice.ts";

packages/client-discord/src/messages.ts

@@ -271,7 +271,7 @@ export class MessageManager {
             if (message.author.bot) {
                 if (this._isTeamMember(authorId) && !isDirectlyMentioned) {
                     return;
-                } else if (
+                }if (
                     this.runtime.character.clientConfig.discord
                         .shouldIgnoreBotMessages
                 ) {
@@ -295,7 +295,7 @@ export class MessageManager {
                 attachments.push(...processedAudioAttachments);
             }
 
-            const roomId = stringToUuid(channelId + "-" + this.runtime.agentId);
+            const roomId = stringToUuid(`${channelId}-${this.runtime.agentId}`);
             const userIdUUID = stringToUuid(userId);
 
             await this.runtime.ensureConnection(
@@ -307,7 +307,7 @@ export class MessageManager {
             );
 
             const messageId = stringToUuid(
-                message.id + "-" + this.runtime.agentId
+                `${message.id}-${this.runtime.agentId}`
             );
 
             let shouldIgnore = false;
@@ -320,9 +320,7 @@ export class MessageManager {
                 url: message.url,
                 inReplyTo: message.reference?.messageId
                     ? stringToUuid(
-                          message.reference.messageId +
-                              "-" +
-                              this.runtime.agentId
+                          `${message.reference.messageId}-${this.runtime.agentId}`
                       )
                     : undefined,
             };
@@ -335,7 +333,7 @@ export class MessageManager {
             };
 
             const memory: Memory = {
-                id: stringToUuid(message.id + "-" + this.runtime.agentId),
+                id: stringToUuid(`${message.id}-${this.runtime.agentId}`),
                 ...userMessage,
                 userId: userIdUUID,
                 agentId: this.runtime.agentId,
@@ -728,7 +726,7 @@ export class MessageManager {
 
                                 // Create and store memories
                                 const memories = messages.map(m => ({
-                                    id: stringToUuid(m.id + "-" + this.runtime.agentId),
+                                    id: stringToUuid(`${m.id}-${this.runtime.agentId}`),
                                     userId: this.runtime.agentId,
                                     agentId: this.runtime.agentId,
                                     content: {

packages/client-discord/src/providers/voiceState.ts

@@ -12,7 +12,7 @@ const voiceStateProvider: Provider = {
         );
         const agentName = state?.agentName || "The agent";
         if (!connection) {
-            return agentName + " is not currently in a voice channel";
+            return `${agentName} is not currently in a voice channel`;
         }
 
         const channel = (
@@ -23,7 +23,7 @@ const voiceStateProvider: Provider = {
         );
 
         if (!channel || channel.type !== ChannelType.GuildVoice) {
-            return agentName + " is in an invalid voice channel";
+            return `${agentName} is in an invalid voice channel`;
         }
 
         return `${agentName} is currently in the voice channel: ${channel.name} (ID: ${channel.id})`;

packages/core/src/generation.ts

@@ -304,6 +304,7 @@ async function generateEnum<T extends string>({
             modelClass,
             output: 'enum',
             enum: enumValues,
+            mode: 'json'
         });
 
         elizaLogger.debug("Received enum response:", result);
@@ -322,7 +323,7 @@ export async function generateShouldRespond({
     context: string;
     modelClass: ModelClass;
 }): Promise<"RESPOND" | "IGNORE" | "STOP" | null> {
-    const RESPONSE_VALUES = ['RESPOND', 'IGNORE', 'STOP'];
+    const RESPONSE_VALUES = ['RESPOND', 'IGNORE', 'STOP'] as string[];
 
     const result = await generateEnum({
         runtime,