Fixed goal updating bug in the goal evaluator's handler (#2725)

Co-authored-by: Sayo <hi@sayo.wtf>

Author: Alirun

packages/plugin-bootstrap/src/evaluators/goal.ts

@@ -80,34 +80,18 @@ async function handler(
 
     // Apply the updates to the goals
     const updatedGoals = goalsData
-        .map((goal: Goal) => {
+        .map((goal: Goal): Goal => {
             const update = updates?.find((u) => u.id === goal.id);
             if (update) {
-                const objectives = goal.objectives;
-
-                // for each objective in update.objectives, find the objective with the same description in 'objectives' and set the 'completed' value to the update.objectives value
-                if (update.objectives) {
-                    for (const objective of objectives) {
-                        const updatedObjective = update.objectives.find(
-                            (o: Objective) =>
-                                o.description === objective.description
-                        );
-                        if (updatedObjective) {
-                            objective.completed = updatedObjective.completed;
-                        }
-                    }
-                }
-
+                // Merge the update into the existing goal
                 return {
                     ...goal,
                     ...update,
-                    objectives: [
-                        ...goal.objectives,
-                        ...(update?.objectives || []),
-                    ],
-                }; // Merging the update into the existing goal
-            } else {
-                console.warn("**** ID NOT FOUND");
+                    objectives: goal.objectives.map((objective) => {
+                        const updatedObjective = update.objectives?.find(uo => uo.id === objective.id);
+                        return updatedObjective ? { ...objective, ...updatedObjective } : objective;
+                    }),
+                };
             }
             return null; // No update for this goal
         })