fix: test/lint develop (#2266)

* bump version

* add eslint config

* remove unused error var per lint

* fix lint

* comment out duplicate symbol

* prefix address as it's not used per lint

* add _ prefix for unused vars per lint

* remove unused error per lint

* prefix unused vars with _ per lint

* remove unused error per lint

* don't import unused ServiceType per lint

* remove unused vars per lint

* rename test per lint

* lint auto fixes

* deTS it per lint

* deTS per lint

* bump

Author: odilitime

packages/plugin-binance/eslint.config.mjs

@@ -0,0 +1,3 @@
+import eslintGlobalConfig from "../../eslint.config.mjs";
+
+export default [...eslintGlobalConfig];

packages/plugin-binance/src/actions/spotBalance.ts

@@ -47,7 +47,7 @@ export const spotBalance: Action = {
         try {
             await validateBinanceConfig(runtime);
             return true;
-        } catch (error) {
+        } catch {
             return false;
         }
     },

packages/plugin-genlayer/eslint.config.mjs

@@ -0,0 +1,3 @@
+import eslintGlobalConfig from "../../eslint.config.mjs";
+
+export default [...eslintGlobalConfig];

packages/plugin-giphy/eslint.config.mjs

@@ -0,0 +1,3 @@
+import eslintGlobalConfig from "../../eslint.config.mjs";
+
+export default [...eslintGlobalConfig];

packages/plugin-nft-collections/eslint.config.mjs

@@ -0,0 +1,3 @@
+import eslintGlobalConfig from "../../eslint.config.mjs";
+
+export default [...eslintGlobalConfig];

packages/plugin-nft-collections/package.json

@@ -9,7 +9,7 @@
         "build": "tsup src/index.ts --format esm --dts",
         "test": "vitest run",
         "test:watch": "vitest",
-        "lint": "eslint src --ext .ts",
+        "lint": "eslint --fix --cache .",
         "format": "prettier --write src/**/*.ts"
     },
     "dependencies": {
@@ -22,7 +22,7 @@
         "@types/node": "^20.11.16",
         "@typescript-eslint/eslint-plugin": "^6.21.0",
         "@typescript-eslint/parser": "^6.21.0",
-        "eslint": "^8.56.0",
+        "eslint": "^9.16.0",
         "prettier": "^3.2.5",
         "tsup": "^8.0.1",
         "typescript": "^5.3.3",

packages/plugin-nft-collections/src/constants/curated-collections.ts

@@ -8,7 +8,7 @@ export const CollectionCategory = z.enum([
     "Iconic Gems",
 ]);
 
-export type CollectionCategory = z.infer<typeof CollectionCategory>;
+//export type CollectionCategory = z.infer<typeof CollectionCategory>;
 
 export const CuratedCollectionSchema = z.object({
     address: z.string(),

packages/plugin-nft-collections/src/services/market-intelligence.ts

@@ -16,7 +16,7 @@ export class MarketIntelligenceService {
         this.rateLimiter = config.rateLimiter;
     }
 
-    async getMarketIntelligence(address: string): Promise<MarketData> {
+    async getMarketIntelligence(_address: string): Promise<MarketData> {
         // Implementation will be added later
         return {
             floorPrice: 0,

packages/plugin-nft-collections/src/services/reservoir.ts

@@ -218,19 +218,19 @@ export class ReservoirService {
         return Promise.resolve({} as MarketStats);
     }
 
-    async getCollectionActivity(collectionAddress: string): Promise<any> {
+    async getCollectionActivity(_collectionAddress: string): Promise<any> {
         return Promise.resolve(null);
     }
 
-    async getCollectionTokens(collectionAddress: string): Promise<any> {
+    async getCollectionTokens(_collectionAddress: string): Promise<any> {
         return Promise.resolve(null);
     }
 
-    async getCollectionAttributes(collectionAddress: string): Promise<any> {
+    async getCollectionAttributes(_collectionAddress: string): Promise<any> {
         return Promise.resolve(null);
     }
 
-    async getFloorListings(options: {
+    async getFloorListings(_options: {
         collection: string;
         limit: number;
         sortBy: "price" | "rarity";
@@ -245,7 +245,7 @@ export class ReservoirService {
         return Promise.resolve([]);
     }
 
-    async executeBuy(options: {
+    async executeBuy(_options: {
         listings: Array<{
             tokenId: string;
             price: number;
@@ -266,7 +266,7 @@ export class ReservoirService {
         });
     }
 
-    async createListing(options: {
+    async createListing(_options: {
         tokenId: string;
         collectionAddress: string;
         price: number;
@@ -288,7 +288,7 @@ export class ReservoirService {
         });
     }
 
-    async cancelListing(options: {
+    async cancelListing(_options: {
         listingId: string;
         marketplace: "ikigailabs";
     }): Promise<{
@@ -301,7 +301,7 @@ export class ReservoirService {
         });
     }
 
-    async getOwnedNFTs(owner: string): Promise<
+    async getOwnedNFTs(_owner: string): Promise<
         Array<{
             tokenId: string;
             collectionAddress: string;

packages/plugin-nft-collections/src/services/security-manager.ts

@@ -45,7 +45,7 @@ export class SecurityManager {
 
         try {
             return JSON.parse(decrypted);
-        } catch (error) {
+        } catch {
             throw new Error('Failed to decrypt or parse data');
         }
     }

packages/plugin-nft-collections/src/services/social-analytics.ts

@@ -16,25 +16,25 @@ export class SocialAnalyticsService {
         this.rateLimiter = config.rateLimiter;
     }
 
-    async getSocialMetrics(address: string): Promise<SocialMetrics> {
+    async getSocialMetrics(_address: string): Promise<SocialMetrics> {
         // Implementation will be added later
         return {
             lastUpdate: new Date().toISOString(),
         };
     }
 
     async getCommunityMetrics(
-        address: string,
-        discordId?: string,
-        telegramId?: string
+        _address: string,
+        _discordId?: string,
+        _telegramId?: string
     ): Promise<SocialMetrics> {
         // Implementation will be added later
         return {
             lastUpdate: new Date().toISOString(),
         };
     }
 
-    async analyzeSentiment(address: string): Promise<{
+    async analyzeSentiment(_address: string): Promise<{
         overall: number;
         breakdown: {
             positive: number;
@@ -59,7 +59,7 @@ export class SocialAnalyticsService {
         };
     }
 
-    async trackSocialPerformance(address: string): Promise<{
+    async trackSocialPerformance(_address: string): Promise<{
         metrics: {
             reach: number;
             engagement: number;

packages/plugin-nft-collections/src/types.ts

@@ -1,4 +1,4 @@
-import { Service, ServiceType } from "@elizaos/core";
+import { Service } from "@elizaos/core";
 
 declare module "@elizaos/core" {
     interface ServiceTypeMap {

packages/plugin-nft-collections/src/utils/validation.ts

@@ -111,7 +111,7 @@ export function validatePriceRange(price: number): boolean {
 export function sanitizeCollectionData(data: unknown): Partial<NFTCollection> {
     try {
         return NFTCollectionSchema.parse(data);
-    } catch (error) {
+    } catch {
         // Return only the valid fields
         const partial = {};
         const validFields = Object.entries(

packages/plugin-opacity/eslint.config.mjs

@@ -0,0 +1,3 @@
+import eslintGlobalConfig from "../../eslint.config.mjs";
+
+export default [...eslintGlobalConfig];

packages/plugin-opacity/src/index.ts

@@ -43,7 +43,6 @@ export class OpacityAdapter implements IVerifiableInferenceAdapter {
         // Get provider-specific endpoint
         let endpoint;
         let authHeader;
-        let responseRegex;
 
         switch (provider) {
             case ModelProviderName.OPENAI:
@@ -97,7 +96,7 @@ export class OpacityAdapter implements IVerifiableInferenceAdapter {
             // Validate JSON before sending
             try {
                 JSON.parse(requestBody); // Verify the JSON is valid
-            } catch (e) {
+            } catch {
                 elizaLogger.error("Invalid JSON body:", body);
                 throw new Error("Failed to create valid JSON request body");
             }

packages/plugin-tee-verifiable-log/src/test/deriveProvider.test.ts

@@ -18,7 +18,7 @@ describe("DeriveProvider", () => {
             });
             expect(keys).not.toBeNull();
         });
-        it("should deriveKeyPair when available", async () => {
+        it("should deriveKeyPair when available 2", async () => {
             const agentId = uuidv4();
             const plantText = "Helo World";
             const { success, errorMsg, ivHex, encryptedData } =

packages/plugin-tee-verifiable-log/src/test/providers.test.ts

@@ -28,7 +28,7 @@ describe("SQLite3VerifiableDAO", () => {
     });
     describe("VerifiableLogProvider Management", () => {
         it("should verifiableLogProvider.log when available", async () => {
-            let uid = uuidv4();
+            const uid = uuidv4();
             await verifiableLogProvider.log(
                 {
                     agentId: uid,
@@ -75,7 +75,7 @@ describe("SQLite3VerifiableDAO", () => {
 
     describe("SQLite3VerifiableDAO Management", () => {
         it("should addLog and pageQueryLogs when available", async () => {
-            let testId = uuidv4();
+            const testId = uuidv4();
             await sqLite3VerifiableDAO.addLog(<VerifiableLog>{
                 id: testId,
                 agent_id: "dddd",

packages/plugin-whatsapp/__tests__/client.test.ts

@@ -15,10 +15,10 @@ vi.mock('axios', () => {
 });
 
 describe('WhatsAppClient', () => {
-    let client: WhatsAppClient;
-    let mockPost: any;
-    
-    const mockConfig: WhatsAppConfig = {
+    let client;
+    let mockPost;
+
+    const mockConfig = {
         accessToken: 'test-token',
         phoneNumberId: 'test-phone-id',
         webhookVerifyToken: 'test-webhook-token',
@@ -28,12 +28,12 @@ describe('WhatsAppClient', () => {
     beforeEach(() => {
         vi.clearAllMocks();
         client = new WhatsAppClient(mockConfig);
-        mockPost = (axios.create() as any).post;
+        mockPost = (axios.create()).post;
     });
 
     describe('sendMessage', () => {
         it('should send a text message correctly', async () => {
-            const mockMessage: WhatsAppMessage = {
+            const mockMessage = {
                 type: 'text',
                 to: '1234567890',
                 content: 'Hello, World!'
@@ -57,7 +57,7 @@ describe('WhatsAppClient', () => {
         });
 
         it('should send a template message correctly', async () => {
-            const mockMessage: WhatsAppMessage = {
+            const mockMessage = {
                 type: 'template',
                 to: '1234567890',
                 content: {
@@ -93,7 +93,7 @@ describe('WhatsAppClient', () => {
         });
 
         it('should handle API errors correctly', async () => {
-            const mockMessage: WhatsAppMessage = {
+            const mockMessage = {
                 type: 'text',
                 to: '1234567890',
                 content: 'Hello, World!'
@@ -108,7 +108,7 @@ describe('WhatsAppClient', () => {
 
     describe('verifyWebhook', () => {
         it('should verify webhook token correctly', async () => {
-            const result = await client.verifyWebhook(mockConfig.webhookVerifyToken!);
+            const result = await client.verifyWebhook(mockConfig.webhookVerifyToken);
             expect(result).toBe(true);
         });
 

packages/plugin-whatsapp/__tests__/handlers/webhook.handler.test.ts

@@ -4,12 +4,12 @@ import { WhatsAppClient } from '../../src/client';
 import { WhatsAppWebhookEvent } from '../../src/types';
 
 describe('WebhookHandler', () => {
-    let webhookHandler: WebhookHandler;
-    let mockClient: WhatsAppClient;
-    let consoleSpy: any;
+    let webhookHandler;
+    let mockClient;
+    let consoleSpy;
 
     beforeEach(() => {
-        mockClient = {} as WhatsAppClient;
+        mockClient = {};
         webhookHandler = new WebhookHandler(mockClient);
         consoleSpy = vi.spyOn(console, 'log');
     });
@@ -28,7 +28,7 @@ describe('WebhookHandler', () => {
             }
         };
 
-        const mockEvent: WhatsAppWebhookEvent = {
+        const mockEvent = {
             object: 'whatsapp_business_account',
             entry: [{
                 id: 'BUSINESS_ID',
@@ -58,7 +58,7 @@ describe('WebhookHandler', () => {
             recipient_id: '1234567890'
         };
 
-        const mockEvent: WhatsAppWebhookEvent = {
+        const mockEvent = {
             object: 'whatsapp_business_account',
             entry: [{
                 id: 'BUSINESS_ID',
@@ -98,7 +98,7 @@ describe('WebhookHandler', () => {
             recipient_id: '1234567890'
         };
 
-        const mockEvent: WhatsAppWebhookEvent = {
+        const mockEvent = {
             object: 'whatsapp_business_account',
             entry: [{
                 id: 'BUSINESS_ID',
@@ -123,11 +123,11 @@ describe('WebhookHandler', () => {
     });
 
     it('should handle errors correctly', async () => {
-        const mockEvent = {} as WhatsAppWebhookEvent;
-        
+        const mockEvent = {};
+
         // The handler should not throw an error for an empty event
         await expect(webhookHandler.handle(mockEvent)).resolves.not.toThrow();
-        
+
         // Verify that no messages or statuses were processed
         expect(consoleSpy).not.toHaveBeenCalled();
     });