Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The length of the arrow becomes 2 bonds after layout but should be 1 #2519

Closed
AnnaKosol opened this issue Oct 7, 2024 · 5 comments · Fixed by #2587, #2642 or #2639
Closed

The length of the arrow becomes 2 bonds after layout but should be 1 #2519

AnnaKosol opened this issue Oct 7, 2024 · 5 comments · Fixed by #2587, #2642 or #2639
Assignees
@AliaksandrDziarkach
Labels
Layout Priority: Medium Team G
Milestone
Indigo-1.27.0-rc.2

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. add the reaction to the Canvas
Screenshot 2024-10-07 at 16 04 20

!rxn-v2000-reaction-2x2.rxn.zip

  1. click on layout

Actual behavior
The length of the arrow becomes 2 bonds
Screenshot 2024-10-07 at 16 07 43

Expected behavior
The length of the arrow becomes 1 bonds
Screenshot 2024-10-07 at 16 08 34

Environment details:

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • MacOs
  • Chrome 129.0.6668.71 (Official Build) (arm64)

Issue found while testing #2176
@AnnaKosol AnnaKosol added this to the Indigo-1.25.0-rc.2 milestone Oct 7, 2024
@AlexeyGirin AlexeyGirin changed the title The length of the arrow becomes 2 bonds except 1 after layout The length of the arrow becomes 2 bonds except 1 after layout - RECHECK Oct 23, 2024
@AlexeyGirin
Copy link
Collaborator

Reproduced at

  • Ketcher Version 2.26.0-rc.5 Build at 2024-10-21; 15:27:55
  • Indigo Toolkit Version 1.25.0-rc.3.0-g795119115-wasm32-wasm-clang-19.0.0
  • Chrome Version Version 130.0.6723.59 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin changed the title The length of the arrow becomes 2 bonds except 1 after layout - RECHECK The length of the arrow becomes 2 bonds except 1 after layout Oct 24, 2024
@AliaksandrDziarkach AliaksandrDziarkach changed the title The length of the arrow becomes 2 bonds except 1 after layout The length of the arrow becomes 2 bonds after layout but should be 1 Oct 25, 2024
AliaksandrDziarkach added a commit that referenced this issue Oct 28, 2024
@AliaksandrDziarkach
#2519 - The length of the arrow becomes 2 bonds after layout but sho…
50a517f 
…uld be 1

Fix code. Update UTs
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 28, 2024 that will close this issue
#2519 - The length of the arrow becomes 2 bonds after layout but should be 1 #2587
Merged
7 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 29, 2024
@AliaksandrDziarkach
#2519 - The length of the arrow becomes 2 bonds after layout but sho…
cbc50b4 
…uld be 1 (#2587)

Co-authored-by: Aliakasndr Dziarkach <Aliakasndr.Dziarkach@gmail.com>
@AlexeyGirin AlexeyGirin reopened this Nov 11, 2024
@AlexeyGirin
Copy link
Collaborator

Not fixed.
Arrow size should be equal to bond size as per requirement:

Bond length - length of one bond and the length of the default arrows (related issue: epam/ketcher#5153);

image

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

@Zhirnoff
Copy link
Collaborator

2024-11-07_17h18_36.mp4

@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Nov 16, 2024
AliaksandrDziarkach added a commit that referenced this issue Nov 16, 2024
@AliaksandrDziarkach
#2519 - The length of the arrow becomes 2 bonds after layout but sho…
1e4395b 
…uld be 1

Fix default bond length to 1. Update UTs
AliaksandrDziarkach added a commit that referenced this issue Nov 18, 2024
@AliaksandrDziarkach
Backmerge: #2519 - The length of the arrow becomes 2 bonds after layo…
cdeb567 
…ut but should be 1

Backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Nov 20, 2024 that will close this issue
Backmerge: #2519 - The length of the arrow becomes 2 bonds after layout but should be 1 #2642
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Nov 20, 2024
@AliaksandrDziarkach
#2519 - The length of the arrow becomes 2 bonds after layout but sho…
969f552 
…uld be 1 (#2639)

Co-authored-by: Aliakasndr Dziarkach <Aliakasndr.Dziarkach@gmail.com>
AlexanderSavelyev pushed a commit that referenced this issue Nov 20, 2024
@AliaksandrDziarkach
Backmerge: #2519 - The length of the arrow becomes 2 bonds after layo…
5326047 
…ut but should be 1 (#2642)
@even1024 even1024 removed this from the Indigo-1.26.0-rc.3 milestone Dec 3, 2024
@even1024 even1024 added this to the Indigo-1.26.0-rc.4 milestone Dec 3, 2024
@even1024 even1024 reopened this Dec 3, 2024
@even1024
Copy link
Collaborator

even1024 commented Dec 3, 2024

Not merged into 1.26.0.

@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-12-26_10h54_27

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.4]
Indigo version
[Version 1.27.0-rc.2]

@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jan 10, 2025 that will close this issue
#2519 - The length of the arrow becomes 2 bonds after layout but should be 1 #2639
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Layout Priority: Medium Team G
Projects
None yet
Milestone
Indigo-1.27.0-rc.2
6 participants
@even1024 @AliaksandrDziarkach @AlexeyGirin @Zhirnoff @AnnaKosol @AlekseiKhariukov