Added in a retry so that when kldload does its first interface creation it works. (#4)

* changed timeout to 2 seconds

for sloweer systems I have changed the ATH10K_HTC_WAIT_TIMEOUT_MSEC to 2 seconds instead.

* took back the change.

Instead i'll implement a system that unloads the firmware when the capabilities don't come in correctly and the firmware load crashes. kldload and unload should not have to deal with internal driver issues.

* add code to force the driver to attempt to retry to load the interface up to 6 times.

add code to force the driver to attempt to retry to load the interface up to 6 times. This should fix kldload issues, as long as the wifi card will work during boot we can automate bringing up the interface in scripts. Thats our first goal.

* re-order

* re-trying probe fw until sucessful or errors at the 6th try.

* undo changes

* attempt at retrying to wait for htc to complete and return

stopping hif and restarting hif if htc wait target doesnt finish succesfully.

* removed return on hif_stop

* attemping to recall ath10k_core_probe_fw

trying to reset the atheros chip to to load up properly on error.

* add sleep statement

sleep a little to let the device catch up and be ready.

* dumb auto programming features of VSCode capatilized Sleep

* not use to freebsd kernel developing.

I decided to use pause_sig in the case a signal called us to release before we end sleeping.

* added in a ath10k_core_stop

need to stop the core its not being called on error. I also have set bmi.done_sent = false.

* oops forgot semicolon

* test removing ath10k_core_stop from retrying probe and just hack bmi.done_sent

* cleaened up my hack for probe retrying

turned the probe retry in to functional code and added a retry limit to core.h called ATH10K_FW_PROBE_RETRYS

* forgot struct def

* added function to cleanup memory leaks

added a function to the process that allows us to cleanup any memory leaks if there are any.

* removed pause_sig

pause_sig isn't being used anywhere else and pause_sig is a delay based function which does not put the thread in the sleep queue so I switched it to tsleep instead.

* removed line of code from ath10k

Author: Geramy

.gitignore

@@ -0,0 +1,2 @@
+
+otus/freebsd/src/sys/.vscode/c_cpp_properties.json

otus/freebsd/src/sys/dev/athp/if_athp_core.c

@@ -1690,18 +1690,47 @@ ath10k_core_probe_fw(struct ath10k *ar)
 	return ret;
 }
 
+/*
+ This function has been made to do cleanup to prevent memory leaks if any exist.
+First step tell bmi done has not been sent so it will re-setup bmi.
+*/
+static void
+clean_ath10k_core_probe_fw(struct ath10k * ar) 
+{
+	ar->bmi.done_sent = false;
+}
+
+/*
+ anum is the number of attempts that have been tried.
+This is to reload the firmware multiple times because sometimes it fails for no reason,
+it may be a freebsd only issue.
+*/
+static int
+attempt_ath10k_core_probe_fw(struct ath10k *ar, int anum) 
+{
+	int status = ath10k_core_probe_fw(ar);
+	if (status) {
+		ath10k_err(ar, "could not probe fw, clean up allocations and memory and retry. (%d)\n", status);
+		tsleep(ar, 1, "pausing to wait for the ath cpu to be ready.", 250);
+		if(anum < ATH10K_FW_PROBE_RETRIES) {
+			clean_ath10k_core_probe_fw(ar);
+			return attempt_ath10k_core_probe_fw(ar, anum++);
+		}
+	}
+	return status;
+}
+
 static void
 ath10k_core_register_work(void *arg, int npending)
 {
 	struct ath10k *ar = arg;
 	int status;
 
-	status = ath10k_core_probe_fw(ar);
+	status = attempt_ath10k_core_probe_fw(ar, 0);
 	if (status) {
 		ath10k_err(ar, "could not probe fw (%d)\n", status);
 		goto err;
 	}
-
 	status = ath10k_mac_register(ar);
 	if (status) {
 		ath10k_err(ar, "could not register to mac80211 (%d)\n", status);

otus/freebsd/src/sys/dev/athp/if_athp_core.h

@@ -29,6 +29,7 @@
 #define ATH10K_FLUSH_TIMEOUT_HZ (5)
 #define ATH10K_CONNECTION_LOSS_HZ (3)
 #define ATH10K_NUM_CHANS 39
+#define ATH10K_FW_PROBE_RETRIES 6
 
 /* Antenna noise floor */
 #define ATH10K_DEFAULT_NOISE_FLOOR -95

otus/freebsd/src/sys/dev/athp/if_athp_main.c

@@ -509,12 +509,11 @@ athp_transmit(struct ieee80211com *ic, struct mbuf *m0)
 
 	return (0);
 }
-
 /*
  * Handle initial notifications about starting the interface here.
  */
 static void
-athp_parent(struct ieee80211com *ic)
+athp_parent(struct ieee80211com *ic, int attempts)
 {
 	struct ath10k *ar = ic->ic_softc;
 
@@ -540,6 +539,12 @@ athp_parent(struct ieee80211com *ic)
 				ath10k_err(ar,
 				    "%s: ath10k_start failed; ret=%d\n",
 				    __func__, ret);
+					if (attempts < 6) {
+						ath10k_err(ar,
+						"%s: ath10k_start failed, trying again; ret=%d\n",
+						__func__, ret);
+						athp_parent(ic, attempts++);
+					}
 				return;
 			}
 
@@ -588,6 +593,14 @@ athp_parent(struct ieee80211com *ic)
 	}
 }
 
+/*
+* Handle the athp_parent call but attempt retries and starting the interface here
+*/
+static void
+net80211_athp_parent(struct ieee80211com *ic) {
+	athp_parent(ic, 0);
+}
+
 #if 0
 /*
  * STA mode BSS update - deferred since node additions need deferring.
@@ -2424,7 +2437,7 @@ athp_attach_net80211(struct ath10k *ar)
 	ic->ic_set_channel = athp_set_channel;
 	ic->ic_transmit = athp_transmit;
 	ic->ic_send_mgmt = athp_send_mgmt;
-	ic->ic_parent = athp_parent;
+	ic->ic_parent = net80211_athp_parent;
 	ic->ic_vap_create = athp_vap_create;
 	ic->ic_vap_delete = athp_vap_delete;
 	ic->ic_wme.wme_update = athp_wme_update;