[athp] add debug section for BSS config, move the WME setup into it

This is also pretty loud and now i know it works fine, it can be
off by default.

Whilst here sprinkle some comments and #if 0 stuff around some stuff.

Author: Adrian Chadd

otus/freebsd/src/sys/dev/athp/if_athp_debug.h

@@ -54,6 +54,7 @@
 #define	ATH10K_DBG_KEYCACHE	0x100000000ULL
 #define	ATH10K_DBG_BEACON	0x200000000ULL
 #define	ATH10K_DBG_HTT_TX	0x400000000ULL
+#define	ATH10K_DBG_BSS_CONF	0x800000000ULL
 #define	ATH10K_DBG_ANY		0xffffffff
 
 enum ath10k_pktlog_filter {

otus/freebsd/src/sys/dev/athp/if_athp_mac.c

@@ -6840,13 +6840,9 @@ static int ath10k_conf_tx(struct ath10k *ar,
 	 */
 	p->txop = IEEE80211_TXOP_TO_US(wmep->wmep_txopLimit);
 
-	ath10k_warn(ar, "%s: ac=%d, cwmin=%d, cwmax=%d, aifs=%d, txop=%d\n",
-	    __func__,
-	    ac,
-	    p->cwmin,
-	    p->cwmax,
-	    p->aifs,
-	    p->txop);
+	ath10k_dbg(ar, ATH10K_DBG_BSS_CONF,
+	    "%s: ac=%d, cwmin=%d, cwmax=%d, aifs=%d, txop=%d\n",
+	    __func__, ac, p->cwmin, p->cwmax, p->aifs, p->txop);
 
 	/*
 	 * This is configuring the VAP WME parameters, not the per-node
@@ -6878,6 +6874,10 @@ static int ath10k_conf_tx(struct ath10k *ar,
 	return ret;
 }
 
+/*
+ * Note: remain on channel has to do with P2P off-channel
+ * work like P2P setup.
+ */
 #if 0
 
 #define ATH10K_ROC_TIMEOUT_HZ (2)
@@ -6985,7 +6985,9 @@ static int ath10k_cancel_remain_on_channel(struct ieee80211_hw *hw)
 
 	return 0;
 }
+#endif
 
+#if 0
 /*
  * Both RTS and Fragmentation threshold are interface-specific
  * in ath10k, but device-specific in mac80211.