Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 37273c9

Browse files
erwinpan1erwinpan1
committedOct 2, 2024·
Fix comformance issues
checked by python ./src/python_testing/TC_DeviceBasicComposition.py --storage-path admin_storage.json --manual-code 34970112332 --bool-arg ignore_in_progress:True allow_provisional:True --PICS src/app/tests/suites/certification/ci-pics-values python ./src/python_testing/TC_DeviceConformance.py --storage-path admin_storage.json --manual-code 34970112332 --bool-arg ignore_in_progress:True allow_provisional:True --PICS src/app/tests/suites/certification/ci-pics-values
1 parent 4ad1253 commit 37273c9

3 files changed

+46
-12
lines changed
 

‎examples/chef/common/clusters/refrigerator-and-temperature-controlled-cabinet-mode/tcc-mode.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ void emberAfRefrigeratorAndTemperatureControlledCabinetModeClusterInitCallback(c
150150
VerifyOrDie(gTccModeDelegate == nullptr && gTccModeInstance == nullptr);
151151
gTccModeDelegate = new RefrigeratorAndTemperatureControlledCabinetMode::TccModeDelegate;
152152
gTccModeInstance = new ModeBase::Instance(gTccModeDelegate, 0x1, RefrigeratorAndTemperatureControlledCabinetMode::Id,
153-
chip::to_underlying(Feature::kOnOff));
153+
0);
154154
gTccModeInstance->Init();
155155
}
156156

‎examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter

+7-5
Original file line numberDiff line numberDiff line change
@@ -1415,7 +1415,7 @@ endpoint 0 {
14151415
callback attribute generatedCommandList;
14161416
callback attribute acceptedCommandList;
14171417
callback attribute attributeList;
1418-
ram attribute featureMap default = 0;
1418+
ram attribute featureMap default = 0x1;
14191419
callback attribute clusterRevision;
14201420
}
14211421

@@ -1471,7 +1471,7 @@ endpoint 0 {
14711471
callback attribute acceptedCommandList;
14721472
callback attribute attributeList;
14731473
ram attribute featureMap default = 0;
1474-
ram attribute clusterRevision default = 1;
1474+
ram attribute clusterRevision default = 2;
14751475

14761476
handle command ArmFailSafe;
14771477
handle command ArmFailSafeResponse;
@@ -1562,7 +1562,7 @@ endpoint 0 {
15621562
callback attribute generatedCommandList;
15631563
callback attribute acceptedCommandList;
15641564
callback attribute attributeList;
1565-
ram attribute featureMap default = 0;
1565+
ram attribute featureMap default = 0x1;
15661566
ram attribute clusterRevision default = 1;
15671567

15681568
handle command OpenCommissioningWindow;
@@ -1665,6 +1665,7 @@ endpoint 2 {
16651665
callback attribute serverList;
16661666
callback attribute clientList;
16671667
callback attribute partsList;
1668+
callback attribute tagList;
16681669
callback attribute generatedCommandList;
16691670
callback attribute acceptedCommandList;
16701671
callback attribute attributeList;
@@ -1695,7 +1696,7 @@ endpoint 2 {
16951696
callback attribute eventList;
16961697
callback attribute attributeList;
16971698
ram attribute featureMap default = 0;
1698-
ram attribute clusterRevision default = 1;
1699+
ram attribute clusterRevision default = 4;
16991700
}
17001701
}
17011702
endpoint 3 {
@@ -1707,6 +1708,7 @@ endpoint 3 {
17071708
callback attribute serverList;
17081709
callback attribute clientList;
17091710
callback attribute partsList;
1711+
callback attribute tagList;
17101712
callback attribute generatedCommandList;
17111713
callback attribute acceptedCommandList;
17121714
callback attribute attributeList;
@@ -1737,7 +1739,7 @@ endpoint 3 {
17371739
callback attribute eventList;
17381740
callback attribute attributeList;
17391741
ram attribute featureMap default = 0;
1740-
ram attribute clusterRevision default = 1;
1742+
ram attribute clusterRevision default = 4;
17411743
}
17421744
}
17431745

‎examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.zap

+38-6
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@
361361
"storageOption": "RAM",
362362
"singleton": 0,
363363
"bounded": 0,
364-
"defaultValue": "0",
364+
"defaultValue": "0x1",
365365
"reportable": 1,
366366
"minInterval": 1,
367367
"maxInterval": 65534,
@@ -1184,7 +1184,7 @@
11841184
"storageOption": "RAM",
11851185
"singleton": 0,
11861186
"bounded": 0,
1187-
"defaultValue": "1",
1187+
"defaultValue": "2",
11881188
"reportable": 1,
11891189
"minInterval": 0,
11901190
"maxInterval": 65344,
@@ -2197,7 +2197,7 @@
21972197
"storageOption": "RAM",
21982198
"singleton": 0,
21992199
"bounded": 0,
2200-
"defaultValue": "0",
2200+
"defaultValue": "0x1",
22012201
"reportable": 1,
22022202
"minInterval": 1,
22032203
"maxInterval": 65534,
@@ -3264,6 +3264,22 @@
32643264
"maxInterval": 65534,
32653265
"reportableChange": 0
32663266
},
3267+
{
3268+
"name": "TagList",
3269+
"code": 4,
3270+
"mfgCode": null,
3271+
"side": "server",
3272+
"type": "array",
3273+
"included": 1,
3274+
"storageOption": "External",
3275+
"singleton": 0,
3276+
"bounded": 0,
3277+
"defaultValue": null,
3278+
"reportable": 1,
3279+
"minInterval": 1,
3280+
"maxInterval": 65534,
3281+
"reportableChange": 0
3282+
},
32673283
{
32683284
"name": "GeneratedCommandList",
32693285
"code": 65528,
@@ -3656,7 +3672,7 @@
36563672
"storageOption": "RAM",
36573673
"singleton": 0,
36583674
"bounded": 0,
3659-
"defaultValue": "1",
3675+
"defaultValue": "4",
36603676
"reportable": 1,
36613677
"minInterval": 1,
36623678
"maxInterval": 65534,
@@ -3765,6 +3781,22 @@
37653781
"maxInterval": 65534,
37663782
"reportableChange": 0
37673783
},
3784+
{
3785+
"name": "TagList",
3786+
"code": 4,
3787+
"mfgCode": null,
3788+
"side": "server",
3789+
"type": "array",
3790+
"included": 1,
3791+
"storageOption": "External",
3792+
"singleton": 0,
3793+
"bounded": 0,
3794+
"defaultValue": null,
3795+
"reportable": 1,
3796+
"minInterval": 1,
3797+
"maxInterval": 65534,
3798+
"reportableChange": 0
3799+
},
37683800
{
37693801
"name": "GeneratedCommandList",
37703802
"code": 65528,
@@ -4157,7 +4189,7 @@
41574189
"storageOption": "RAM",
41584190
"singleton": 0,
41594191
"bounded": 0,
4160-
"defaultValue": "1",
4192+
"defaultValue": "4",
41614193
"reportable": 1,
41624194
"minInterval": 1,
41634195
"maxInterval": 65534,
@@ -4202,4 +4234,4 @@
42024234
"parentEndpointIdentifier": null
42034235
}
42044236
]
4205-
}
4237+
}

0 commit comments

Comments
 (0)
Please sign in to comment.