Skip to content

Commit 3da1865

Browse files
cecilleerwinpan1
authored andcommitted
TC-ACE-2.1/2: Add commissioning step (project-chip#31715)
This is apparently what the TH is using to determine if a test requires commissioning, so we best add it.
1 parent 6c48126 commit 3da1865

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/python_testing/TC_AccessChecker.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ async def _run_write_access_test_for_cluster_privilege(self, endpoint_id, cluste
198198
await self.TH2.WriteAttribute(nodeid=self.dut_node_id, attributes=[(endpoint_id, attribute(val))])
199199

200200
async def run_access_test(self, test_type: AccessTestType):
201-
# Step 1 and 2 are handled in the class setup, but need to be marked for every test
201+
# Step precondition, 1 and 2 are handled in the class setup, but need to be marked for every test
202+
self.step("precondition")
202203
self.step(1)
203204
self.step(2)
204205
# Read all the attributes on TH2 using admin access
@@ -234,7 +235,8 @@ async def run_access_test(self, test_type: AccessTestType):
234235
self.fail_current_test("One or more access violations was found")
235236

236237
def steps_TC_ACE_2_1(self):
237-
steps = [TestStep(1, "TH_commissioner performs a wildcard read"),
238+
steps = [TestStep("precondition", "DUT is commissioned", is_commissioning=True),
239+
TestStep(1, "TH_commissioner performs a wildcard read"),
238240
TestStep(2, "TH_commissioner reads the ACL attribute"),
239241
TestStep(3, "Repeat steps 3a and 3b for each permission level")]
240242
enum = Clusters.AccessControl.Enums.AccessControlEntryPrivilegeEnum
@@ -254,7 +256,8 @@ async def test_TC_ACE_2_1(self):
254256
await self.run_access_test(AccessTestType.READ)
255257

256258
def steps_TC_ACE_2_2(self):
257-
steps = [TestStep(1, "TH_commissioner performs a wildcard read"),
259+
steps = [TestStep("precondition", "DUT is commissioned", is_commissioning=True),
260+
TestStep(1, "TH_commissioner performs a wildcard read"),
258261
TestStep(2, "TH_commissioner reads the ACL attribute"),
259262
TestStep(3, "TH_commissioner grants TH_second_controller admin permission"),
260263
TestStep(4, "TH_second_controller performs a wildcard read"),

0 commit comments

Comments
 (0)